- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 82
Many fixes, come inside for a better explanation #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            Lord-Kamina
  wants to merge
  20
  commits into
  AppImageCrafters:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
Lord-Kamina:fix-deps-final
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Signed-off-by: Gregorio Litenstein <[email protected]>
Signed-off-by: Gregorio Litenstein <[email protected]>
Signed-off-by: Gregorio Litenstein <[email protected]>
Seems I was working on this in parallel to what got merged. My reasoning is this: Use the expanded `-noX` commands that mean the same as `—no-compresion` according to the documentation. By default use zstd compression instead of xz, because the AppImage team has said on at least one occassion that’s what’s going in the standard spec. Signed-off-by: Gregorio Litenstein <[email protected]>
Signed-off-by: Gregorio Litenstein <[email protected]>
Signed-off-by: Gregorio Litenstein <[email protected]>
Signed-off-by: Gregorio Litenstein <[email protected]>
Signed-off-by: Gregorio Litenstein <[email protected]>
This doesn't change the default behavior, but makes the whole workflow much more friendly for people forking this and other AppImageCrafters repos.
Signed-off-by: Gregorio Litenstein <[email protected]>
Signed-off-by: Gregorio Litenstein <[email protected]>
Signed-off-by: Gregorio Litenstein <[email protected]>
c356808    to
    b8f6121      
    Compare
  
    Fix ubuntu linker symlink
debug? Signed-off-by: Gregorio Litenstein <[email protected]> don't need debug anymore
Signed-off-by: Gregorio Litenstein <[email protected]>
Signed-off-by: Gregorio Litenstein <[email protected]>
c104ef5    to
    794b951      
    Compare
  
    So the prelease doesn't being hoarding files. Signed-off-by: Gregorio Litenstein <[email protected]>
794b951    to
    10a8175      
    Compare
  
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
First, sorry for an idiotically big PR... I began working on this when our workflows at https://www.github.com/performous/performous broke recently.
This is part of a larger effort to give whoever steps up as maintainer (I'm not it!) an all-around easier time. It partly relies on other PRs I have submitted at https://github.com/AppImageCrafters/AppRun and https://github.com/AppImageCrafters/tests-env
Here, I have done a number of changes:
APPIMAGE_BUILDER_PY_VERSION: This will be set automatically when running the script, and it's populated fromsys.version_info. The idea is to use this in python recipes, and then you don't need to update them when there are updates to python.APPIMAGE_BUILDER_REMOTE_REPO_OWNER: This will hold the repository-owner for any parts of the code that download or reference things from other repos. The idea is if somebody forks all three repos (appimage-builder, AppRun and tests-env) they can still have CI working on their forks. It's populated from the environment in__main__.py(and the CI workflows by default set it to${{ github.repository_owner }}, withappimagecraftersas a default fallback.setup.py, migrating completely topyproject.tomlappimage-builderandbashrecipes.Below I will paste my explanation to a teammate of why I had to change some things in AppRun, as well as the structure of symlinks.
This will probably take a while to digest and be reviewed properly but I'm willing to answer any questions.
In the meantime, you can go over to my fork and see how the CI works and download what should be a working appimage-builder AppImage made with python 3.12