Skip to content

fix: Adjust theme for Material 3 changes #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 39 commits into
base: main
Choose a base branch
from
Open

fix: Adjust theme for Material 3 changes #134

wants to merge 39 commits into from

Conversation

soeren-schmaljohann-2denker
Copy link
Contributor

These are the global theme changes, the rest will be done in the individual apps, with seperate PRs.

@github-actions github-actions bot added the p:theme Changes to apptive_grid_theme label Nov 29, 2023
@soeren-schmaljohann-2denker soeren-schmaljohann-2denker changed the title Ac 3888 material 3 theme adjustments fix: Adjust theme for Material 3 changes Nov 29, 2023
ABausG
ABausG reviewed Nov 29, 2023
View reviewed changes
Copy link
Contributor

@ABausG ABausG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tints still seem to look weird. Maybe also take a look into adding a golden test for Bottom Sheets to make sure they look correct in terms of shape and tint as well.

packages/apptive_grid_theme/test/src/goldens/ci/alert_dialog.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an unwanted tint on the dialogs

packages/apptive_grid_theme/test/src/goldens/ci/switch.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tint of the switch in an unselected state looks wrong

christian2denker and others added 17 commits February 24, 2024 16:50
@github-actions github-actions bot added p:core Changes to apptive_grid_core p:form Changes to apptive_grid_form p:grid_builder Changes to apptive_grid_grid_builder labels Oct 31, 2024
@github-actions github-actions bot added the p:user_management Changes to apptive_grid_user_management label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ABausG ABausG ABausG left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@soeren-schmaljohann-2denker soeren-schmaljohann-2denker

Labels
p:core Changes to apptive_grid_core p:form Changes to apptive_grid_form p:grid_builder Changes to apptive_grid_grid_builder p:theme Changes to apptive_grid_theme p:user_management Changes to apptive_grid_user_management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soeren-schmaljohann-2denker @ABausG @christian2denker @gmeral