use slots to calculate size in memory #914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcusDenker
approved these changes
Aug 1, 2025
Contributor
MarcusDenker
left a comment
MarcusDenker
left a comment
There was a problem hiding this comment.
So this is recursive version of sizeInMemory.
To improve (but I think not really needed for this use in Soil):
- Slots that are virtual (but that is not used in real code, thus we can ignore it for now and just filter for them if we would use them)
- Objects that have some variable layout but not inherit from Collection (but for those we can just implement #soilSizeInMemory if needed).
I guess idea to improve could be to delegate iteration to the Layout, this could be done for both for iterating over variable size objects and the slots.
Contributor
Author
|
Not sure we need a PhD about it 😉 This is only used by persitent cluster to measure how much is cached in memory. So only usable if it is certain there are no loops etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.