Skip to content

Conversation

Troyhy
Copy link

@Troyhy Troyhy commented Jun 8, 2025

Integrated MapTiler API key into the application, replacing the hardcoded key with a dynamic environment variable. Updated relevant code, documentation, and configuration files to support this change, ensuring flexibility for different environments.

Integrated MapTiler API key into the application, replacing the hardcoded key with a dynamic environment variable. Updated relevant code, documentation, and configuration files to support this change, ensuring flexibility for different environments.
@Troyhy Troyhy mentioned this pull request Jun 8, 2025
Replaced hardcoded Cesium asset ID with a dynamic value sourced from an environment variable. Updated relevant code and configuration files to enhance flexibility across environments.
@Troyhy Troyhy changed the title Add support for MapTiler key configuration Add support for MapTiler key configuration and Cesium resource ID Jun 9, 2025
@Troyhy
Copy link
Author

Troyhy commented Jun 9, 2025

Motivation for this was to get map tiles to work with local development version of UAVLogViewer. Initially I thought that it is needed to have cesium account and some other platform to get map tiles, but noticed that my cesion ion account resource number did not match the viewer. So that's why I initially added the MapTiler account key and then realised that it is not needed. Cesium ion can provide basic map tiles also. So here are both now configurable with env variables.

@Troyhy
Copy link
Author

Troyhy commented Jun 9, 2025

Cesium resource id 3 ( Bing Maps Aerial with Labels)
image
MapTiler
image

Copy link
Collaborator

@Williangalvani Williangalvani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall. just a minor type and I'm not sure where that key came from

VUE_APP_CESIUM_TOKEN: JSON.stringify(process.env.VUE_APP_CESIUM_TOKEN || '')
VUE_APP_CESIUM_TOKEN: JSON.stringify(process.env.VUE_APP_CESIUM_TOKEN || ''),
VUE_APP_CESIUM_RESOURCE_ID: JSON.stringify(process.env.VUE_APP_CESIUM_RESOUR_ID || 3),
VUE_APP_MAPTILER_KEY: JSON.stringify(process.env.VUE_APP_MAPTILER_KEY || 'o3JREHNnXex8WSPPm2BU')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this your key?

NODE_ENV: '"production"',
VUE_APP_CESIUM_TOKEN: JSON.stringify(process.env.VUE_APP_CESIUM_TOKEN || '')
VUE_APP_CESIUM_TOKEN: JSON.stringify(process.env.VUE_APP_CESIUM_TOKEN || ''),
VUE_APP_CESIUM_RESOURCE_ID: JSON.stringify(process.env.VUE_APP_CESIUM_RESOUR_ID || 3),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
VUE_APP_CESIUM_RESOURCE_ID: JSON.stringify(process.env.VUE_APP_CESIUM_RESOUR_ID || 3),
VUE_APP_CESIUM_RESOURCE_ID: JSON.stringify(process.env.VUE_APP_CESIUM_RESOURCE_ID || 3),

Copy link
Collaborator

@Williangalvani Williangalvani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change means we'll have bing maps as the default provider, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants