-
Notifications
You must be signed in to change notification settings - Fork 248
Add support for MapTiler key configuration and Cesium resource ID #444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Integrated MapTiler API key into the application, replacing the hardcoded key with a dynamic environment variable. Updated relevant code, documentation, and configuration files to support this change, ensuring flexibility for different environments.
Replaced hardcoded Cesium asset ID with a dynamic value sourced from an environment variable. Updated relevant code and configuration files to enhance flexibility across environments.
Motivation for this was to get map tiles to work with local development version of UAVLogViewer. Initially I thought that it is needed to have cesium account and some other platform to get map tiles, but noticed that my cesion ion account resource number did not match the viewer. So that's why I initially added the MapTiler account key and then realised that it is not needed. Cesium ion can provide basic map tiles also. So here are both now configurable with env variables. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall. just a minor type and I'm not sure where that key came from
VUE_APP_CESIUM_TOKEN: JSON.stringify(process.env.VUE_APP_CESIUM_TOKEN || '') | ||
VUE_APP_CESIUM_TOKEN: JSON.stringify(process.env.VUE_APP_CESIUM_TOKEN || ''), | ||
VUE_APP_CESIUM_RESOURCE_ID: JSON.stringify(process.env.VUE_APP_CESIUM_RESOUR_ID || 3), | ||
VUE_APP_MAPTILER_KEY: JSON.stringify(process.env.VUE_APP_MAPTILER_KEY || 'o3JREHNnXex8WSPPm2BU') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this your key?
NODE_ENV: '"production"', | ||
VUE_APP_CESIUM_TOKEN: JSON.stringify(process.env.VUE_APP_CESIUM_TOKEN || '') | ||
VUE_APP_CESIUM_TOKEN: JSON.stringify(process.env.VUE_APP_CESIUM_TOKEN || ''), | ||
VUE_APP_CESIUM_RESOURCE_ID: JSON.stringify(process.env.VUE_APP_CESIUM_RESOUR_ID || 3), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VUE_APP_CESIUM_RESOURCE_ID: JSON.stringify(process.env.VUE_APP_CESIUM_RESOUR_ID || 3), | |
VUE_APP_CESIUM_RESOURCE_ID: JSON.stringify(process.env.VUE_APP_CESIUM_RESOURCE_ID || 3), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change means we'll have bing maps as the default provider, right?
Integrated MapTiler API key into the application, replacing the hardcoded key with a dynamic environment variable. Updated relevant code, documentation, and configuration files to support this change, ensuring flexibility for different environments.