Update to bitmask #64
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary fix redefines the hash table to use block coordinates (point / blockSize) instead of individual points, enabling true block-level sparsity and significantly reducing memory usage for sparse 3D grids. Additionally, it corrects memory pool allocation logic, ensuring consistent and safe handling in both thread-safe and non-thread-safe paths, and removes unnecessary error logging for robustness. Bit operations now properly compute local offsets within 8x8x8 blocks, fixing incorrect bit positioning. These changes enhance performance, prevent data corruption, and align the implementation with the intended sparse representation, while retaining the existing BitBlock structure. Note that the documentation still incorrectly references a 32x32x32 block size, which may need future clarification. (edited)