Skip to content

Check if $term->term_id is set before using it to delete the term #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Check if $term->term_id is set before using it to delete the term #982

wants to merge 1 commit into from

Conversation

@georgejipa
Copy link

@georgejipa georgejipa commented Aug 23, 2023

Description

Make sure to check if $term->term_id is set before using it to delete the term. This will fix the following PHP notice:

PHP Notice:  Trying to get property 'term_id' of non-object in [redacted]/wp-content/plugins/co-authors-plus/co-authors-plus.php on line 1064

Steps to Test

  1. Go to Users page.
  2. Try to delete a user who is not an author.

@GaryJones GaryJones added this to the Future milestone Aug 23, 2023
@GaryJones GaryJones changed the base branch from main to develop August 25, 2023 15:20
@GaryJones GaryJones modified the milestones: Future, 3.5.15, 3.5.16 Aug 25, 2023
@GaryJones GaryJones modified the milestones: 3.6.1, 3.6.2 Apr 25, 2024
@GaryJones GaryJones modified the milestones: 3.6.2, 3.6.5 Mar 25, 2025
@GaryJones GaryJones modified the milestones: 3.6.5, 3.6.6 Apr 15, 2025
@GaryJones GaryJones modified the milestones: 3.6.6, 3.6.7 Jun 9, 2025
@GaryJones GaryJones modified the milestones: 3.6.7, Next patch Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Status: needs investigation Type: bug

Projects

None yet

Milestone

Next patch

Development

Successfully merging this pull request may close these issues.

2 participants

@georgejipa @GaryJones