Skip to content

Conversation

@enejb
Copy link
Member

@enejb enejb commented Nov 14, 2025

Resolves FORMS-408

This PR updates the icons to now be buttons.

In order to make this happen. We use a single word an tooltips to make things a bit more clear.

Before:

Screenshot 2025-11-14 at 1 05 06 PM

After:
Screenshot 2025-11-14 at 1 04 41 PM

Proposed changes:

  • Update the design to use a single word instead of the icons.
  • Added a tooltip to show clarify the action even more.
  • Made sure that the other icons only take up as little space as possible so that things to end up in two lines.
  • Decreased the hotizontal spacing even more that the current buttons take up so that things don't end up in two lines.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

no

Does this pull request change what data or activity we track or use?

no

Testing instructions:

Go to the Dashboard.

  • Notice that now the icons are gone for the actions.
  • Open up a single view. Notice the new copy. notice the new tooltips and the aria labels.
  • Resize the window notice that we don't end up in a state where the actions are on two lines in english.

Updated button labels and aria-labels for response actions and navigation to be more descriptive and accessible. Changed button variant and styling for consistency. Adjusted layout in response view and refined button padding in SCSS. Also shortened action labels for read/unread in dataviews actions.
@enejb enejb requested review from a team and Copilot November 14, 2025 21:10
@enejb enejb added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. [Package] Forms labels Nov 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/forms-update-to-words-menu branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/forms-update-to-words-menu

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@enejb enejb changed the title Update/forms update to words menu Forms Update to use words in the singel response actions. Nov 14, 2025
@enejb enejb changed the title Forms Update to use words in the singel response actions. Forms Update to use words in the single response actions. Nov 14, 2025
Copilot finished reviewing on behalf of enejb November 14, 2025 21:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Forms dashboard inbox UI by replacing icon-only action buttons with text-based buttons to improve clarity and usability.

  • Simplified action button labels from phrases like "Mark as read" to single words like "Read"
  • Converted icon-only buttons to text buttons with tooltips for better user experience
  • Adjusted spacing and layout to prevent button wrapping on smaller screens

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 13 comments.

Show a summary per file
File Description
projects/packages/forms/src/dashboard/inbox/dataviews/actions.tsx Shortened action labels from "Mark as read"/"Mark as unread" to "Read"/"Unread"
projects/packages/forms/src/dashboard/components/response-actions/index.tsx Converted buttons from icon-only to text-based with tooltips and reduced horizontal padding
projects/packages/forms/src/dashboard/components/response-view/style.scss Added CSS rule to reduce button padding (8px left/right) for space efficiency
projects/packages/forms/src/dashboard/components/response-view/single.tsx Fixed navigation container width to prevent layout wrapping
projects/packages/forms/src/dashboard/components/response-navigation/index.tsx Enhanced button labels with more descriptive text (e.g., "Previous response" instead of "Previous")
projects/packages/forms/changelog/update-forms-update-to-words-menu Added changelog entry documenting the icon-to-label transition

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

<ResponseActions onActionComplete={ handleActionComplete } response={ sidePanelItem } />
</HStack>
<HStack alignment="right">
<HStack alignment="right" style={ { width: '96px', minWidth: '96px' } }>
Copy link

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider moving the inline style to a CSS class for better maintainability. Inline styles with hardcoded pixel values make it harder to adjust responsive behavior and maintain consistency across the codebase. This width/minWidth constraint could be defined in the stylesheet with a semantic class name like jp-forms__response-navigation-container.

Suggested change
<HStack alignment="right" style={ { width: '96px', minWidth: '96px' } }>
<HStack alignment="right" className="jp-forms__response-navigation-container">

Copilot uses AI. Check for mistakes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Copilot here. These are magic numbers a bit and potentially need adjusting for mobile?

}
}

.jp-forms__response-actions .components-button {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should be able to handle these spacings with HStack component; we sort of rarely need to add things like these anymore.

isPrimary: false,
icon: <Icon icon={ seen } />,
label: __( 'Mark as read', 'jetpack-forms' ),
label: __( 'Read', 'jetpack-forms' ),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilonagl I'm not sure this is a good rename; it's clearer "mark as read" in the dropdown

Image

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@jp-launch-control
Copy link

jp-launch-control bot commented Nov 14, 2025

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Contact Form [Package] Forms [Status] Needs Review This PR is ready for review. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants