-
Notifications
You must be signed in to change notification settings - Fork 841
Forms Update to use words in the single response actions. #45947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Updated button labels and aria-labels for response actions and navigation to be more descriptive and accessible. Changed button variant and styling for consistency. Adjusted layout in response view and refined button padding in SCSS. Also shortened action labels for read/unread in dataviews actions.
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Forms dashboard inbox UI by replacing icon-only action buttons with text-based buttons to improve clarity and usability.
- Simplified action button labels from phrases like "Mark as read" to single words like "Read"
- Converted icon-only buttons to text buttons with tooltips for better user experience
- Adjusted spacing and layout to prevent button wrapping on smaller screens
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| projects/packages/forms/src/dashboard/inbox/dataviews/actions.tsx | Shortened action labels from "Mark as read"/"Mark as unread" to "Read"/"Unread" |
| projects/packages/forms/src/dashboard/components/response-actions/index.tsx | Converted buttons from icon-only to text-based with tooltips and reduced horizontal padding |
| projects/packages/forms/src/dashboard/components/response-view/style.scss | Added CSS rule to reduce button padding (8px left/right) for space efficiency |
| projects/packages/forms/src/dashboard/components/response-view/single.tsx | Fixed navigation container width to prevent layout wrapping |
| projects/packages/forms/src/dashboard/components/response-navigation/index.tsx | Enhanced button labels with more descriptive text (e.g., "Previous response" instead of "Previous") |
| projects/packages/forms/changelog/update-forms-update-to-words-menu | Added changelog entry documenting the icon-to-label transition |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
projects/packages/forms/src/dashboard/components/response-navigation/index.tsx
Show resolved
Hide resolved
| <ResponseActions onActionComplete={ handleActionComplete } response={ sidePanelItem } /> | ||
| </HStack> | ||
| <HStack alignment="right"> | ||
| <HStack alignment="right" style={ { width: '96px', minWidth: '96px' } }> |
Copilot
AI
Nov 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider moving the inline style to a CSS class for better maintainability. Inline styles with hardcoded pixel values make it harder to adjust responsive behavior and maintain consistency across the codebase. This width/minWidth constraint could be defined in the stylesheet with a semantic class name like jp-forms__response-navigation-container.
| <HStack alignment="right" style={ { width: '96px', minWidth: '96px' } }> | |
| <HStack alignment="right" className="jp-forms__response-navigation-container"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Copilot here. These are magic numbers a bit and potentially need adjusting for mobile?
projects/packages/forms/src/dashboard/components/response-actions/index.tsx
Show resolved
Hide resolved
projects/packages/forms/src/dashboard/components/response-actions/index.tsx
Show resolved
Hide resolved
projects/packages/forms/src/dashboard/components/response-actions/index.tsx
Show resolved
Hide resolved
projects/packages/forms/changelog/update-forms-update-to-words-menu
Outdated
Show resolved
Hide resolved
projects/packages/forms/src/dashboard/components/response-actions/index.tsx
Show resolved
Hide resolved
projects/packages/forms/src/dashboard/components/response-actions/index.tsx
Show resolved
Hide resolved
projects/packages/forms/src/dashboard/components/response-actions/index.tsx
Show resolved
Hide resolved
projects/packages/forms/src/dashboard/components/response-navigation/index.tsx
Show resolved
Hide resolved
…-menu Co-authored-by: Copilot <[email protected]>
| } | ||
| } | ||
|
|
||
| .jp-forms__response-actions .components-button { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should be able to handle these spacings with HStack component; we sort of rarely need to add things like these anymore.
| isPrimary: false, | ||
| icon: <Icon icon={ seen } />, | ||
| label: __( 'Mark as read', 'jetpack-forms' ), | ||
| label: __( 'Read', 'jetpack-forms' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilonagl I'm not sure this is a good rename; it's clearer "mark as read" in the dropdown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
projects/packages/forms/src/dashboard/components/response-actions/index.tsx
Outdated
Show resolved
Hide resolved
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
Resolves FORMS-408
This PR updates the icons to now be buttons.
In order to make this happen. We use a single word an tooltips to make things a bit more clear.
Before:
After:

Proposed changes:
Other information:
Jetpack product discussion
no
Does this pull request change what data or activity we track or use?
no
Testing instructions:
Go to the Dashboard.