src/backend-dbus/actions.c: Fix MATE lockdown support (don't require … #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…org.gnome.desktop.lockdown gsettings to be set, honour org.mate.desktop.lockdown gsettings instead).
sunweaver
force-pushed
the
personal/sunweaver/mate-lockdown-support
branch
from
de1afa6 to
69772c4
Compare
|
@gber Can you review this? |
|
@gber Please only merge GPG-signed. I normally do this via "View command line instructions" and add a "-S" to the git merge command. |
gber
suggested changes
Aug 7, 2025
| { | ||
| priv_t * p; | ||
| GSettings * s; | ||
| GSettings * s = null; |
| { | ||
| s = g_settings_new ("org.gnome.desktop.lockdown"); | ||
| } | ||
| elif (ayatana_common_utils_is_mate()) |
| g_signal_connect_swapped (s, "changed::disable-user-switching", | ||
| G_CALLBACK(indicator_session_actions_notify_can_switch), self); | ||
| p->lockdown_settings = s; | ||
| } |
There was a problem hiding this comment.
So now we have the possibility that p->lockdown_settings might no longer be set here, does indicator_session_actions_dbus_get_instance_private() ensure that it is initialized to NULL and does the code handling it expect it to be null?
There was a problem hiding this comment.
If you're not sure about this it might be a better idea to check for Mate and else assume GNOME.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…org.gnome.desktop.lockdown gsettings to be set, honour org.mate.desktop.lockdown gsettings instead).