Skip to content

Conversation

@charlielye
Copy link
Contributor

  • We remove all the sync shennanigans from noir.
  • The noir-repo-ref file contains 2 lines, first is repo tag, second is npm semver.
  • OR the noir-repo-ref contains a fork url/branch.
  • The former uses noirup to install noir at the given tag. It uses the second line in forwarding packages in noir/packages.
  • In second case we clone the repo from the fork and use noirup to install from that clone, plus build the packages as before.
  • yarn-project is unchanged in this model. It still uses the "republished" noir packages within @Aztec npm org.
  • This means we still have optionality to have our own builds and releases if we need to.
  • Follow up PR will look to install the same noir version on the host in install scripts. We can probably ignore the unhappy path case of their being local edits for now. It's not likely needed, but if it is, can add support to clone and install (puts a little extra toolchain effort on end user).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants