-
Notifications
You must be signed in to change notification settings - Fork 538
fix: qol for running fuzzer #17913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: qol for running fuzzer #17913
Conversation
| "include": ["src"] | ||
| "include": ["src"], | ||
| // Note(ilyas): This exclude kinda redundant now, but a reminder for when we move the fuzzer into /src/avm | ||
| "exclude": ["scripts/fuzzing/avm_simulator_bin.ts"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it feels weird to me that the fuzzer currently lives in scripts but if we want to move it to within src we should add it to the excludes here. As it shouldn't be part of the normal build
The fuzzer instrumentation only works with CommonJS (aka requires) while the rest of our build uses ESM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My fault that it's in scripts/. I suggested that it be moved there. It does kind of feell like a script to me, but I can be convinced otherwise. My thinking was "this is a script wrapping the AVM to feed it line-by-line inputs."
803d6de to
324eca6
Compare
4b826c1 to
ba3179a
Compare
| "include": ["src"] | ||
| "include": ["src"], | ||
| // Note(ilyas): This exclude kinda redundant now, but a reminder for when we move the fuzzer into /src/avm | ||
| "exclude": ["scripts/fuzzing/avm_simulator_bin.ts"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My fault that it's in scripts/. I suggested that it be moved there. It does kind of feell like a script to me, but I can be convinced otherwise. My thinking was "this is a script wrapping the AVM to feed it line-by-line inputs."
ba3179a to
721dad4
Compare
This (hopefully) makes it easier to run the avm<>brillig fuzzer via the magic of a claude-cobbled script.
The script (optionally) takes in 3 paths to the
noir-repo,avm-transpiler, andfuzzer-binaryrespectively. If not provided the default should work for a standard aztec-packages layout.