Skip to content

fix: type issues in storage reads #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: type issues in storage reads #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/test/first.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ unconstrained fn test_initializer() {

let block_number = get_block_number();
let admin_slot = EasyPrivateVoting::storage_layout().admin.slot;
let admin_storage_value = storage_read(voting_contract_address, admin_slot, block_number);
assert(admin_storage_value == admin, "Admin should be correctly stored");
let admin_storage_value: Field = storage_read(voting_contract_address, admin_slot, block_number);
assert(admin_storage_value == admin.into(), "Admin should be correctly stored");
}

#[test]
Expand All @@ -22,7 +22,7 @@ unconstrained fn test_check_vote_status() {

let block_number = get_block_number();
let status_slot = EasyPrivateVoting::storage_layout().vote_ended.slot;
let vote_ended_read: bool = storage_read(voting_contract_address, status_slot, block_number);
let vote_ended_read: bool = storage_read(voting_contract_address, status_slot, block_number).try_into().unwrap();
assert(vote_ended_expected == vote_ended_read, "Vote ended should be false");
}

Expand All @@ -37,7 +37,7 @@ unconstrained fn test_end_vote() {

let block_number = get_block_number();
let status_slot = EasyPrivateVoting::storage_layout().vote_ended.slot;
let vote_ended_read: bool = storage_read(voting_contract_address, status_slot, block_number);
let vote_ended_read: bool = storage_read(voting_contract_address, status_slot, block_number).try_into().unwrap();
assert(vote_ended_expected == vote_ended_read, "Vote ended should be true");
}

Expand All @@ -63,8 +63,8 @@ unconstrained fn test_cast_vote() {
// Read vote count from storage
let block_number = get_block_number();
let tally_slot = EasyPrivateVoting::storage_layout().tally.slot;
let candidate_tally_slot = derive_storage_slot_in_map(tally_slot, candidate);
let vote_count: u32 = storage_read(voting_contract_address, candidate_tally_slot, block_number);
let candidate_tally_slot = derive_storage_slot_in_map(tally_slot, candidate.into());
let vote_count: u32 = storage_read(voting_contract_address, candidate_tally_slot, block_number).try_into().unwrap();

assert(vote_count == 1, "vote tally should be incremented");
}
Expand All @@ -88,8 +88,8 @@ unconstrained fn test_cast_vote_with_separate_accounts() {
// Read vote count from storage
let block_number = get_block_number();
let tally_slot = EasyPrivateVoting::storage_layout().tally.slot;
let candidate_tally_slot = derive_storage_slot_in_map(tally_slot, candidate);
let vote_count: u32 = storage_read(voting_contract_address, candidate_tally_slot, block_number);
let candidate_tally_slot = derive_storage_slot_in_map(tally_slot, candidate.into());
let vote_count: u32 = storage_read(voting_contract_address, candidate_tally_slot, block_number).try_into().unwrap();

assert(vote_count == 2, "vote tally should be 2");
}
Expand Down
Loading