Skip to content

Tracing: add useful tags to Trigger spans #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Tracing: add useful tags to Trigger spans #253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions extension/WebJobs.Extensions.RabbitMQ/Trigger/RabbitMQListener.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,9 @@ public Task StartAsync(CancellationToken cancellationToken)
async Task ReceivedHandler(object model, BasicDeliverEventArgs args)
{
using Activity activity = RabbitMQActivitySource.StartActivity(args.BasicProperties);
activity?.AddTag("amqp.queue", this.queue);
activity?.AddTag("amqp.channel", this.channel);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.channel is not a string so it cannot be used here. maybe we can have args.DeliveryTag instead.

activity?.AddTag("amqp.bodySize", args.Body.Length);

var input = new TriggeredFunctionData() { TriggerValue = args };

Expand All @@ -118,6 +121,7 @@ async Task ReceivedHandler(object model, BasicDeliverEventArgs args)
args.BasicProperties.Headers ??= new Dictionary<string, object>();
args.BasicProperties.Headers.TryGetValue(RequeueCountHeaderName, out object headerValue);
int requeueCount = Convert.ToInt32(headerValue, CultureInfo.InvariantCulture) + 1;
activity?.AddTag("amqp.requeueCount", requeueCount);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds vague since this would show requeueCount=1 even when the is message not requeued. i suggest modifying to

activity?.AddTag("amqp.currentRequeueCount", requeueCount-1);


if (requeueCount >= 5)
{
Expand Down