-
Notifications
You must be signed in to change notification settings - Fork 4.1k
{CDN}Add Edge action support #28720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
{CDN}Add Edge action support #28720
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive Edge Action support to the Azure CDN PowerShell module. The changes include new cmdlets for managing Edge Actions, Edge Action Versions, Edge Action Execution Filters, and Edge Action Attachments.
Key changes:
- Added 17 new cmdlets for complete Edge Action lifecycle management including Create, Read, Update, Delete operations
- Added support for Edge Action version management with code deployment capabilities
- Integrated new API specification for Edge Actions (2024-07-22-preview)
Reviewed Changes
Copilot reviewed 74 out of 74 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Az.Cdn.psd1 | Updated module manifest to export new Edge Action cmdlets |
| Cdn.sln | Updated project GUID reference for autorest module |
| help/*.md | Added comprehensive help documentation for all new Edge Action cmdlets |
| test/*.Tests.ps1 | Added test stubs for all new Edge Action cmdlets |
| examples/*.md | Added usage examples for new Edge Action cmdlets |
| docs/*.md | Added detailed documentation for new Edge Action cmdlets |
| UX/Microsoft.Cdn/edgeActions.json | Added UX metadata for Edge Action cmdlets |
| README.md | Added reference to new Edge Action API specification |
| generate-info.json | Updated generation ID for new autorest run |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good. Please add tests and check out these questions
| Accept wildcard characters: False | ||
| ``` | ||
|
|
||
| ### -IsDefaultVersion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a boolean, should it be?
| ### UpdateExpanded (Default) | ||
| ``` | ||
| Update-AzCdnEdgeAction -Name <String> -ResourceGroupName <String> [-SubscriptionId <String>] | ||
| [-SkuName <String>] [-SkuTier <String>] [-Tag <Hashtable>] [-DefaultProfile <PSObject>] [-AsJob] [-NoWait] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you actually update the SKU? It's immutable for many resource types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will check later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the feature owner, it can be updated.
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.