-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[Storage] Storage account planned failover GA #28728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for storage account planned failover in the Azure Storage PowerShell module, enhancing the existing failover functionality to include a new failover type parameter. The changes enable users to perform both planned and unplanned failovers while providing additional geo-replication statistics to help inform failover decisions.
Key changes:
- Added a new
FailoverTypeparameter toInvoke-AzStorageAccountFailovercmdlet with support for "Planned" and "Unplanned" options - Extended
PSGeoReplicationStatsmodel with three new properties:CanPlannedFailover,PostFailoverRedundancy, andPostPlannedFailoverRedundancy - Updated help documentation with new examples demonstrating planned and unplanned failover scenarios
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Invoke-AzStorageAccountFailover.md | Updated cmdlet help to document the new FailoverType parameter and added examples for planned and unplanned failover scenarios |
| Get-AzStorageAccount.md | Added new example showing geo-replication stats retrieval and corrected grammar in existing example titles |
| StorageAccountBaseCmdlet.cs | Added AccountFailoverType struct to define Planned and Unplanned failover type constants |
| InvokeAzureStorageAccountFailover.cs | Implemented FailoverType parameter, added failover type validation logic, and refactored execution into separate method |
| PSGeoReplicationStats.cs | Extended model with three new geo-replication properties and refactored object initialization to use object initializer syntax |
| ChangeLog.md | Added changelog entry documenting the new planned failover feature |
| StorageAccountTests.ps1 | Added assertions to verify new geo-replication stats properties in test |
src/Storage/Storage.Management/help/Invoke-AzStorageAccountFailover.md
Outdated
Show resolved
Hide resolved
src/Storage/Storage.Management/help/Invoke-AzStorageAccountFailover.md
Outdated
Show resolved
Hide resolved
src/Storage/Storage.Management.Test/ScenarioTests/StorageAccountTests.ps1
Show resolved
Hide resolved
…lover.md Co-authored-by: Copilot <[email protected]>
…lover.md Co-authored-by: Copilot <[email protected]>
|
|
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.