fix: fixing exclude region inclusion #43602
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where customer-provided excluded regions were not being honored during transient failures when the SDK calls the global endpoint, which could point to an excluded region. It also adds logging enhancements to provide proper context when regions are marked unavailable.
Key changes:
- Modified region selection logic to properly respect both user-excluded and circuit-breaker-excluded locations
- Added context parameters to endpoint unavailability tracking methods for better diagnostics
- Updated retry policy to calculate retries based on applicable (non-excluded) regions
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test_service_request_retry_policy_async.py | New async test verifying write failover respects excluded regions during service request errors |
| test_service_request_retry_policy.py | New sync test verifying write failover respects excluded regions during service request errors |
| test_location_cache.py | Added tests for excluded region handling, regional fallback behavior, and global endpoint fallback scenarios |
| _global_endpoint_manager_async.py | Added context parameter to endpoint unavailability tracking methods and their call sites |
| _service_request_retry_policy.py | Updated retry count calculation to use applicable (non-excluded) regional routing contexts and added context to mark_endpoint_unavailable calls |
| _location_cache.py | Refactored region filtering logic to properly separate user-excluded from circuit-breaker-excluded locations and respect exclusions in global endpoint resolution |
| _global_endpoint_manager.py | Added context parameter to endpoint unavailability tracking methods and their call sites |
| _endpoint_discovery_retry_policy.py | Added context parameter when marking endpoints unavailable |
sdk/cosmos/azure-cosmos/tests/test_service_request_retry_policy_async.py
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/tests/test_service_request_retry_policy.py
Outdated
Show resolved
Hide resolved
tvaron3
reviewed
Oct 24, 2025
| return write_regional_routing_context.get_primary() | ||
| if self.connection_policy.EnableEndpointDiscovery: | ||
| # Get the list of applicable write locations, which respects excluded locations. | ||
| applicable_contexts = self._get_applicable_write_regional_routing_contexts(request) |
There was a problem hiding this comment.
I think this will break 403.3 scenarios where we want to ignore preferred regions. I think would be better to add the needed routing logic in session retry policy.
There was a problem hiding this comment.
Tomas, I refactored the code. Do you think it will break scenarios where want to ignore preferred regions?
sdk/cosmos/azure-cosmos/tests/test_service_request_retry_policy_async.py
Outdated
Show resolved
Hide resolved
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses scenarios where customer provided excluded region was not being honored during certain transient failures as the SDK ends up calling global endpoint which can point to a region that is part of excluded region list.
It also adds logging enhancements to ensure when a region is marked unavailable we have the proper context.