Skip to content

[Storage] Fix mypy regressions for Blob, Queue, File Share #43610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Storage] Fix mypy regressions for Blob, Queue, File Share #43610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
72f236b
Fixed mypy regressions for Blog
weirongw23-msft Oct 24, 2025
d1f386e
Fixed mypy regressions for Queue
weirongw23-msft Oct 24, 2025
c965aed
Fixed mypy regressions for File Share
weirongw23-msft Oct 24, 2025
84d5cd7
Reverted samples back
weirongw23-msft Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ from ._quick_query_helper import BlobQueryReader
from ._shared.base_client import StorageAccountHostsMixin

class BlobClient(StorageAccountHostsMixin, StorageEncryptionMixin):
container_name: str
blob_name: str
snapshot: Optional[str]
version_id: Optional[str]
def __init__(
self,
account_url: str,
Expand Down
4 changes: 4 additions & 0 deletions sdk/storage/azure-storage-blob/azure/storage/blob/aio/_blob_client_async.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ class BlobClient( # type: ignore[misc]
StorageAccountHostsMixin,
StorageEncryptionMixin,
):
container_name: str
blob_name: str
snapshot: Optional[str]
version_id: Optional[str]
def __init__(
self,
account_url: str,
Expand Down
6 changes: 6 additions & 0 deletions sdk/storage/azure-storage-file-share/azure/storage/fileshare/_directory_client.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,12 @@ from ._models import (
from ._shared.base_client import StorageAccountHostsMixin

class ShareDirectoryClient(StorageAccountHostsMixin):
share_name: str
directory_path: str
snapshot: Optional[str]
allow_trailing_dot: Optional[bool]
allow_source_trailing_dot: Optional[bool]
file_request_intent: Optional[Literal["backup"]]
def __init__(
self,
account_url: str,
Expand Down
7 changes: 7 additions & 0 deletions sdk/storage/azure-storage-file-share/azure/storage/fileshare/_file_client.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,14 @@ from ._models import (
from ._shared.base_client import StorageAccountHostsMixin

class ShareFileClient(StorageAccountHostsMixin):
share_name: str
file_name: str
file_path: List[str]
directory_path: str
snapshot: Optional[str]
allow_trailing_dot: Optional[bool]
allow_source_trailing_dot: Optional[bool]
file_request_intent: Optional[Literal["backup"]]
def __init__(
self,
account_url: str,
Expand Down
4 changes: 4 additions & 0 deletions sdk/storage/azure-storage-file-share/azure/storage/fileshare/_share_client.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,11 @@ from ._models import (
from ._shared.base_client import StorageAccountHostsMixin

class ShareClient(StorageAccountHostsMixin):
share_name: str
snapshot: Optional[str]
allow_trailing_dot: Optional[bool]
allow_source_trailing_dot: Optional[bool]
file_request_intent: Optional[Literal["backup"]]
def __init__(
self,
account_url: str,
Expand Down
6 changes: 6 additions & 0 deletions sdk/storage/azure-storage-file-share/azure/storage/fileshare/aio/_directory_client_async.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,12 @@ from .._shared.base_client import StorageAccountHostsMixin
from .._shared.base_client_async import AsyncStorageAccountHostsMixin

class ShareDirectoryClient(AsyncStorageAccountHostsMixin, StorageAccountHostsMixin): # type: ignore [misc]
share_name: str
directory_path: str
snapshot: Optional[str]
allow_trailing_dot: Optional[bool]
allow_source_trailing_dot: Optional[bool]
file_request_intent: Optional[Literal["backup"]]
def __init__(
self,
account_url: str,
Expand Down
7 changes: 7 additions & 0 deletions sdk/storage/azure-storage-file-share/azure/storage/fileshare/aio/_file_client_async.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,14 @@ from .._shared.base_client import StorageAccountHostsMixin
from .._shared.base_client_async import AsyncStorageAccountHostsMixin

class ShareFileClient(AsyncStorageAccountHostsMixin, StorageAccountHostsMixin): # type: ignore [misc]
share_name: str
file_name: str
file_path: List[str]
directory_path: str
snapshot: Optional[str]
allow_trailing_dot: Optional[bool]
allow_source_trailing_dot: Optional[bool]
file_request_intent: Optional[Literal["backup"]]
def __init__(
self,
account_url: str,
Expand Down
4 changes: 4 additions & 0 deletions sdk/storage/azure-storage-file-share/azure/storage/fileshare/aio/_share_client_async.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,11 @@ from .._shared.base_client import StorageAccountHostsMixin
from .._shared.base_client_async import AsyncStorageAccountHostsMixin

class ShareClient(AsyncStorageAccountHostsMixin, StorageAccountHostsMixin): # type: ignore[misc]
share_name: str
snapshot: Optional[str]
allow_trailing_dot: Optional[bool]
allow_source_trailing_dot: Optional[bool]
file_request_intent: Optional[Literal["backup"]]
def __init__(
self,
account_url: str,
Expand Down
2 changes: 2 additions & 0 deletions sdk/storage/azure-storage-queue/azure/storage/queue/_queue_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,8 @@ class QueueClient(StorageAccountHostsMixin, StorageEncryptionMixin):
:caption: Create the queue client with url and credential.
"""

queue_name: str

def __init__(
self,
account_url: str,
Expand Down
2 changes: 2 additions & 0 deletions sdk/storage/azure-storage-queue/azure/storage/queue/aio/_queue_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,8 @@ class QueueClient( # type: ignore [misc]
:caption: Create the queue client with a connection string.
"""

queue_name: str

def __init__(
self,
account_url: str,
Expand Down