Skip to content

Conversation

@rads-1996
Copy link
Member

Description

Accommodates breaking changes coming from the following PRs in upstream opentelemetry -

open-telemetry/opentelemetry-python#4676

open-telemetry/opentelemetry-python#4654

open-telemetry/opentelemetry-python#4647

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@Copilot Copilot AI review requested due to automatic review settings October 24, 2025 22:45
@rads-1996 rads-1996 marked this pull request as draft October 24, 2025 22:45
@github-actions github-actions bot added the Monitor - Exporter Monitor OpenTelemetry Exporter label Oct 24, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR accommodates breaking changes from upstream OpenTelemetry Python related to logging APIs. The changes primarily involve renaming classes and parameters to align with the new OpenTelemetry SDK structure where LogData is replaced with ReadableLogRecord/ReadWriteLogRecord, LogExporter becomes LogRecordExporter, and Event type usage is updated.

Key changes:

  • Updated imports and type annotations to use ReadableLogRecord instead of LogData
  • Renamed LogExporter to LogRecordExporter and LogExportResult to LogRecordExportResult
  • Updated test mocks and parameter names to reflect the new naming conventions

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
test_types.py Updated imports and mock specs to use LogRecord.event_name instead of Event
test_processor.py Renamed test variables from log_data to readable_log_record
test_manager.py Updated variable names and comments to use readable_log_record terminology
test_performance_counters/test_processor.py Updated mock specs from LogData to ReadableLogRecord
test_performance_counters/test_performance_counters.py Updated mock specs from LogData to ReadableLogRecord
test_logs.py Updated all test data initialization from LogData to ReadWriteLogRecord and LogExportResult to LogRecordExportResult
_exporter.py Updated class inheritance, type annotations, parameter names, and return types to use new LogRecord APIs
_types.py Updated span event parameter type from Event to LogRecord.event_name
_processor.py Updated imports, parameter names, and method signatures to use ReadableLogRecord
_manager.py Updated imports, parameter names, and method implementations to use ReadableLogRecord
_performance_counters/_processor.py Updated imports, parameter names, and method signatures to use ReadableLogRecord
_performance_counters/_manager.py Updated imports, parameter names, and method implementations to use ReadableLogRecord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Monitor - Exporter Monitor OpenTelemetry Exporter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant