Skip to content

Fix a wrong usage of gemspec usage, relax nokogiri & faraday_middleware requirement #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix a wrong usage of gemspec usage, relax nokogiri & faraday_middleware requirement #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,9 @@
#--------------------------------------------------------------------------
source "https://rubygems.org" do
gem "faraday", "~> 1.0", :require => false
gem "faraday_middleware", "~> 1.0.0.rc1", :require => false
gem "faraday_middleware", "~> 1.0", :require => false
gem "net-http-persistent", "~> 4.0", :require => false
if RUBY_VERSION.start_with?("2.3") then
gem "nokogiri", "~> 1.10.4", :require => false
else
gem "nokogiri", "~> 1.11.0.rc2", :require => false
end
gem "nokogiri", "~> 1.10", :require => false

gem "adal", "~> 1.0", :require => false
gem "dotenv", "~> 2.0", :require => false
Expand Down
6 changes: 1 addition & 5 deletions blob/azure-storage-blob.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,7 @@ Gem::Specification.new do |s|
s.required_ruby_version = ">= 2.3.0"

s.add_runtime_dependency("azure-storage-common", "~> 2.0")
if RUBY_VERSION < "2.4.0"
s.add_runtime_dependency("nokogiri", "~> 1.10.4")
else
s.add_runtime_dependency("nokogiri", "~> 1.11.0.rc2")
end
s.add_runtime_dependency("nokogiri", "~> 1.10")

s.add_development_dependency("dotenv", "~> 2.0")
s.add_development_dependency("minitest", "~> 5")
Expand Down
8 changes: 2 additions & 6 deletions common/azure-storage-common.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,9 @@ Gem::Specification.new do |s|
s.required_ruby_version = ">= 2.3.0"

s.add_runtime_dependency('faraday', '~> 1.0')
s.add_runtime_dependency('faraday_middleware', '~> 1.0.0.rc1')
s.add_runtime_dependency('faraday_middleware', '~> 1.0')
s.add_runtime_dependency("net-http-persistent", '~> 4.0')
if RUBY_VERSION < "2.4.0"
s.add_runtime_dependency("nokogiri", "~> 1.10.4")
else
s.add_runtime_dependency("nokogiri", "~> 1.11.0.rc2")
end
s.add_runtime_dependency('nokogiri', '~> 1.10')

s.add_development_dependency("dotenv", "~> 2.0")
s.add_development_dependency("minitest", "~> 5")
Expand Down
6 changes: 1 addition & 5 deletions file/azure-storage-file.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,7 @@ Gem::Specification.new do |s|
s.required_ruby_version = ">= 2.3.0"

s.add_runtime_dependency("azure-storage-common", "~> 2.0")
if RUBY_VERSION < "2.4.0"
s.add_runtime_dependency("nokogiri", "~> 1.10.4")
else
s.add_runtime_dependency("nokogiri", "~> 1.11.0.rc2")
end
s.add_runtime_dependency("nokogiri", "~> 1.10")

s.add_development_dependency("dotenv", "~> 2.0")
s.add_development_dependency("minitest", "~> 5")
Expand Down
6 changes: 1 addition & 5 deletions queue/azure-storage-queue.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,7 @@ Gem::Specification.new do |s|
s.required_ruby_version = ">= 2.3.0"

s.add_runtime_dependency("azure-storage-common", "~> 2.0")
if RUBY_VERSION < "2.4.0"
s.add_runtime_dependency("nokogiri", "~> 1.10.4")
else
s.add_runtime_dependency("nokogiri", "~> 1.11.0.rc2")
end
s.add_runtime_dependency("nokogiri", "~> 1.10")

s.add_development_dependency("dotenv", "~> 2.0")
s.add_development_dependency("minitest", "~> 5")
Expand Down
6 changes: 1 addition & 5 deletions table/azure-storage-table.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,7 @@ Gem::Specification.new do |s|
s.required_ruby_version = ">= 2.3.0"

s.add_runtime_dependency("azure-storage-common", "~> 2.0")
if RUBY_VERSION < "2.4.0"
s.add_runtime_dependency("nokogiri", "~> 1.10.4")
else
s.add_runtime_dependency("nokogiri", "~> 1.11.0.rc2")
end
s.add_runtime_dependency("nokogiri", "~> 1.10")

s.add_development_dependency("dotenv", "~> 2.0")
s.add_development_dependency("minitest", "~> 5")
Expand Down