Skip to content

BHoM_Engine: Fix issues with system types from newer runtimes to older #3488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 15 commits into from
Closed

BHoM_Engine: Fix issues with system types from newer runtimes to older #3488

wants to merge 15 commits into from

Conversation

@IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Apr 1, 2025 •
edited
Loading

Issues addressed by this PR

Closes #3487

Fix issues with types failing to deserialise in newer runtimes.

  • Always call the Base.Create.Type() method for all non-engine types. This was already done for the case that the type was serialised as a string. No reason we should be using the method for when type is serialised as a document as well

    BHoM_Engine/Serialiser_Engine/Compute/Deserialise/Type.cs

    Line 49 in 216ed5f

    Type type = BH.Engine.Base.Create.Type(bson.AsString, true, true);
  • The above handles problems with the m_ExplicitSystemTypes not caught before in the GetType method
  • Fix handling of ref (out) types to handle the case for:
    • Qualified name (check contains rather than ends with)
    • Generic types
  • Add missing explicit system types shown to be failing

Test files

Test file on SharePoint

Changelog

Additional comments

Fraser Greenroyd and others added 12 commits September 21, 2023 10:55
6.3 Deployment (#3178)
7f7abd8
7.0 Deployment (#3224)
d13f40b
7.1 Deployment (#3313)
6fb2838
@al-fisher
7.2 Deployment (#3354)
42bfd85
@IsakNaslundBh
7.3 Deployment (#3415)
ec8a036
@IsakNaslundBh
8.0 Deployment (#3438)
b1eebe8
@michaelhoehn
8.1 Deployment (#3469)
5431b17
@IsakNaslundBh
Remove condition on IsOmNamespace for when to call the Base.Create.Ty…
5b6acef 
…pe method

That method is handlign far more than just oM classes. Should be used for other types as well.
Only keeping the check for IsEngineNamespace as that still should work fine
@IsakNaslundBh
Handle reftypes
af4d19c 
Changing from checking that the string ends with & to instead contains to handle the case of qualified ref type
@IsakNaslundBh
Handle ref type for generic type creation
b88adf5
@IsakNaslundBh
add a check if type is system type, and if so, simply try to create i…
947033e 
…t before running into the rest of all the checks
@IsakNaslundBh
Add two more missing ExplicitSystemTypes shown to be failing
d731183
@IsakNaslundBh IsakNaslundBh added the type:bug Error or unexpected behaviour label Apr 1, 2025
@IsakNaslundBh IsakNaslundBh self-assigned this Apr 1, 2025
@IsakNaslundBh IsakNaslundBh requested a review from pawelbaran April 1, 2025 10:39
@michaelhoehn michaelhoehn removed the request for review from FraserGreenroyd April 1, 2025 12:18
@IsakNaslundBh IsakNaslundBh changed the base branch from main to develop April 3, 2025 07:47
@IsakNaslundBh
Copy link
Contributor Author

Replaced by #3489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adecler adecler Awaiting requested review from adecler adecler is a code owner

@al-fisher al-fisher Awaiting requested review from al-fisher al-fisher is a code owner

@pawelbaran pawelbaran Awaiting requested review from pawelbaran

Assignees

@IsakNaslundBh IsakNaslundBh

Labels

type:bug Error or unexpected behaviour

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BHoM_Engine: Issues deserialising some system types from later runtime in older runtime

3 participants

@IsakNaslundBh @al-fisher @michaelhoehn