DSDE-121/DSDE-152 Add the quality tests into the toolbox #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalmas-bluesquare
requested review from
yannforget
and removed request for
yannforget
dalmas-bluesquare
requested review from
EstebanMontandon,
lpeligry and
yannforget
dalmas-bluesquare
requested review from
lgarridobsq
and removed request for
lpeligry
lgarridobsq
reviewed
Sep 25, 2025
| @@ -0,0 +1,248 @@ | |||
| import inspect | |||
| """ | ||
| raise Exception(exception_message) | ||
|
|
||
| logger.info("Data passed validation check.") |
There was a problem hiding this comment.
Maybe it makes more sense to use OpenHexa logger (so, use current_run.log_info() instead of the logger.info() one)
This way, we can see the logs nicely on OH
|
|
||
| return expectations | ||
|
|
||
| def validate_expectations(self): |
There was a problem hiding this comment.
This function is very nice!
But, in my head, we are going to iteratively improve it, adding more checks
So maybe it makes sense to divide it up a bit to start with?
So that we don't end up with a huge function including all of the validations that is very hard to read/debug/improve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://bluesquare.atlassian.net/jira/software/projects/DSDE/boards/338?selectedIssue=DSDE-167