fix ListToAccumulationNode #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guill
reviewed
Mar 6, 2025
| inputs = cls.INPUT_TYPES() | ||
| if isinstance(input_types, list): | ||
| for input_type in input_types: | ||
| responce = validate_individual(input_type, inputs) |
There was a problem hiding this comment.
Could you fix the typo responce -> response? (I tried to change it myself, but it looks like the option for allowing maintainers to edit this PR was turned off.)
DrJKL
reviewed
Mar 6, 2025
Comment on lines
+49
to
+59
| def validate_inputs(input_types): | ||
| inputs = cls.INPUT_TYPES() | ||
| if isinstance(input_types, list): | ||
| for input_type in input_types: | ||
| responce = validate_individual(input_type, inputs) | ||
| if isinstance(responce, str): | ||
| return responce | ||
| return True | ||
| else: | ||
| return validate_individual(input_types, inputs) | ||
|
|
There was a problem hiding this comment.
Suggested change
| def validate_inputs(input_types): | |
| inputs = cls.INPUT_TYPES() | |
| if isinstance(input_types, list): | |
| for input_type in input_types: | |
| responce = validate_individual(input_type, inputs) | |
| if isinstance(responce, str): | |
| return responce | |
| return True | |
| else: | |
| return validate_individual(input_types, inputs) | |
| def validate_inputs(input_types): | |
| inputs = cls.INPUT_TYPES() | |
| if isinstance(input_types, list): | |
| for input_type in input_types: | |
| response = validate_individual(input_type, inputs) | |
| if isinstance(response, str): | |
| return response | |
| return True | |
| else: | |
| return validate_individual(input_types, inputs) | |
guill
added a commit
that referenced
this pull request
Mar 9, 2025
[fix] Copy of #11 with fix included
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VariantSupport decorator didn't support nodes with
INPUT_IS_LIST = True