Various fixes #85
Open
Various fixes #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it consistent with the computeScrollVectorForPosition function.
While onStart is empty, onStop handles some cleanup in LinearSmoothScroller and should thus call the super function.
The unit returned by calculateSpeedPerPixel is ms/pixel, so to get a pixel distance one has to divide the target time by the "speed".
Otherwise, the layout manager would only layout the current view where item width = recycler width, which in turn can cause weird effects when smooth scrolling: In a production app, we observed the smooth scroller shooting past the target which was the immediate next view, taking an extra round and looping back to the actual target. Setting the extraLayoutSpace to 1 fixes this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌟 Description
I discovered a few bugs while debugging an issue in this library today. Please let me know if I should create separate PRs for these. All changes are mostly self-contained, but the commits touch similar parts of the code and thus partially depend on each other. I wrote descriptions for each issue inside the commit messages. Please don't hesitate to cherry-pick or modify this PR as you wish.
Hopefully, these changes can be upstreamed, since that would be better than continuing to maintain our fork.