chore: reduce tests' flakyness.

Author: bznein

frontends/web/src/components/amount/amount-with-unit.tsx

@@ -104,7 +104,7 @@ export const AmountUnit = ({ rotateUnit, unit }: TAmountUnitProps) => {
   const classRototable = rotateUnit ? (style.rotatable || '') : '';
   const textStyle = `${style.unit || ''} ${classRototable}`;
   return (
-    <span id={`amount-unit-${unit}`} className={textStyle} onClick={rotateUnit}>
+    <span data-testid={`amount-unit-${unit}`} className={textStyle} onClick={rotateUnit}>
       {unit}
     </span>
   );

frontends/web/tests/banner.test.ts

@@ -73,7 +73,7 @@ test('Backup reminder banner is shown when currency is > 1000', async ({ page, h
 
     // Then, cycle through the currency units and verify the banner updates accordingly.
     for (let i = 0; i < units.length; i++) {
-      await page.locator(`header [data-testid="amount-unit-${units[currentIndex]!}"]`).click();
+      await page.locator(`[data-testid="amount-unit-${units[currentIndex]!}"]`).click();
       const nextIndex = (currentIndex + 1) % units.length;
       await page.waitForTimeout(1000); // wait for the UI to update
       await verifyBackupBanner(page, units[nextIndex]!);

frontends/web/tests/base.test.ts

@@ -17,6 +17,7 @@
 import { test } from './helpers/fixtures';
 import { ServeWallet } from './helpers/servewallet';
 import { expect } from '@playwright/test';
+import { deleteAccountsFile, deleteConfigFile } from './helpers/fs';
 
 let servewallet: ServeWallet;
 
@@ -31,10 +32,16 @@ test('App main page loads', async ({ page, host, frontendPort, servewalletPort }
   await test.step('Navigate to the app', async () => {
     await page.goto(`http://${host}:${frontendPort}`);
     const body = page.locator('body');
-    await expect(body).toContainText('Please connect your BitBox and tap the side to continue.');
+    await expect(body).toContainText('Please connect your BitBox and tap the side to continue.'),
+    { timeout: 15000 };
   });
 });
 
-test.afterAll(() => {
-  servewallet.stop();
+test.beforeAll(async () => {
+  deleteAccountsFile();
+  deleteConfigFile();
+});
+
+test.afterAll(async () => {
+  await servewallet.stop();
 });

frontends/web/tests/helpers/regtest.ts

@@ -78,10 +78,10 @@ export async function sendCoins(address: string, amount: number | string): Promi
 
 
 export function launchRegtest(): Promise<ChildProcess> {
-
+  const PROJECT_ROOT = process.env.GITHUB_WORKSPACE || path.resolve(__dirname, '../../..');
   // First, clean up cache and headers.
   try {
-    const basePath = path.resolve(__dirname, '../../../../appfolder.dev/cache');
+    const basePath = path.join(PROJECT_ROOT, 'appfolder.dev/cache');
 
     // Remove headers-rbtc.bin if it exists
     const headersPath = path.join(basePath, 'headers-rbtc.bin');
@@ -101,8 +101,7 @@ export function launchRegtest(): Promise<ChildProcess> {
   } catch (err) {
     console.warn('Warning: Failed to clean up cache or headers before regtest launch:', err);
   }
-
-  const scriptPath = path.resolve(__dirname, '../../../../scripts/run_regtest.sh');
+  const scriptPath = path.join(PROJECT_ROOT, 'scripts/run_regtest.sh');
 
   return new Promise((resolve, reject) => {
     const proc = spawn('bash', [scriptPath], {