frontend: refactor message and remove small and title props #3642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This would help me later with #3623 |
Title was never used, and small only in one place (Send) for the noFeeTargets warning message. Replaced small font in send View by using `<label>` element (most other text elements use Label element on that page, so it shows the smaller font size. Tested by patching the api endpoint with: ```diff diff --git a/frontends/web/src/api/account.ts b/frontends/web/src/api/account.ts index cbef324..2d26f3347 100644 --- a/frontends/web/src/api/account.ts +++ b/frontends/web/src/api/account.ts @@ -20,6 +20,7 @@ import type { TDetailStatus } from './bitsurance'; import type { SuccessResponse } from './response'; import type { NonEmptyArray } from '@/utils/types'; import { apiGet, apiPost } from '@/utils/request'; +// import { FeeTargets } from '@/routes/account/send/feetargets'; export type NativeCoinCode = 'btc' | 'tbtc' | 'rbtc' | 'ltc' | 'tltc' | 'eth' | 'sepeth'; @@ -379,7 +380,7 @@ export type TFeeTargetList = { }; export const getFeeTargetList = (code: AccountCode): Promise<TFeeTargetList> => { - return apiGet(`account/${code}/fee-targets`); + return apiGet(`account/${code}/fee-targets`).then(() => ({ defaultFeeTarget: 'custom', feeTargets: [] })); }; ```
thisconnect
force-pushed
the
frontend-cleanup-message
branch
from
44c4436 to
f22cb0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title was never used, and small only in one place (Send) for the noFeeTargets warning message.
Replaced small font in send View by using
<label>element (most other text elements use Label element on that page, so it shows the smaller font size.Tested by patching the api endpoint with: