Skip to content

backend/bitbox02bootloader: remove var that is now unused #3655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2025
Merged

backend/bitbox02bootloader: remove var that is now unused #3655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions backend/devices/bitbox02bootloader/device.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ import (
"github.com/BitBoxSwiss/bitbox-wallet-app/util/observable"
"github.com/BitBoxSwiss/bitbox-wallet-app/util/observable/action"
"github.com/BitBoxSwiss/bitbox02-api-go/api/bootloader"
"github.com/BitBoxSwiss/bitbox02-api-go/api/common"
bitbox02common "github.com/BitBoxSwiss/bitbox02-api-go/api/common"
"github.com/BitBoxSwiss/bitbox02-api-go/util/semver"
"github.com/sirupsen/logrus"
Expand Down Expand Up @@ -203,10 +202,6 @@ func (device *Device) UpgradeFirmware() error {
return err
}
if err := device.Device.UpgradeFirmware(signedBinary); err != nil {
// Ignore sig errors for the Plus firmware while we are testing with unsigned firmwares.
if plusIsPlaceholder && product == common.ProductBitBox02PlusMulti {
return device.Reboot()
}
return err
}
return nil
Expand Down
3 changes: 0 additions & 3 deletions backend/devices/bitbox02bootloader/firmware.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,6 @@ var firmwareBB02PlusBinaryBTCOnly []byte
var firmwareBB02PlusVersionBTCOnly = semver.NewSemVer(9, 24, 0)
var firmwareBB02PlusMonotonicVersionBtcOnly uint32 = 47

// TODO: set to false / remove before production. This is only to allow upgrading unsigned firmware.
const plusIsPlaceholder = false

//go:embed assets/firmware-bitbox02nova-multi.v9.24.0.signed.bin.gz
var firmwareBB02PlusBinaryMulti []byte
var firmwareBB02PlusVersionMulti = semver.NewSemVer(9, 24, 0)
Expand Down