make xorgproto a dev package #126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These packages contain header files, which are used by the public headers of other packages like libX11. Make them dev package is to have them provided.
When building from git sources the autotools build misses some m4 files.
jkloetzke
reviewed
Oct 20, 2025
Comment on lines
+8
to
+10
| depends: | ||
| - graphics::xorg::utils::util-macros-dev | ||
|
|
There was a problem hiding this comment.
Hmm, seems unrelated to what the commit message says. I think I even built it without this dependency. Why is it needed?
There was a problem hiding this comment.
Right, this is only necessary when building from git sources... I'll keep this as a separate commit on my side..
Comment on lines
+8
to
+9
| - graphics::xorg::proto::xorgproto-dev | ||
| - graphics::xorg::utils::util-macros-dev |
There was a problem hiding this comment.
There is no provideDeps: ['*-dev'] for those. I guess this should be added?
Comment on lines
+14
to
+15
| - graphics::xorg::proto::xorgproto-dev | ||
| - graphics::xorg::utils::util-macros-dev |
There was a problem hiding this comment.
There is no provideDeps: ['*-dev'] for those. I guess this should be added?
| PKG_DESCRIPTION: "X transport library" | ||
|
|
||
| depends: | ||
| - graphics::xorg::utils::util-macros-dev |
There was a problem hiding this comment.
This looks unrelated as well. Why wasn't that needed before?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the build of
kmscubeforx86_64.