Skip to content

Conversation

sixtyfourktec
Copy link
Contributor

Weston provides a libweston, others may want to use.

Weston provides a libweston, others may want to use.
Comment on lines +91 to +95
mesonPackageDev
installCopy "$1/install/" \
"/usr/" "/usr/share/" \
"/usr/share/libweston-14/" \
"/usr/share/libweston-14/protocols/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can pass the additional paths directly to mesonPackageDev:

Suggested change
mesonPackageDev
installCopy "$1/install/" \
"/usr/" "/usr/share/" \
"/usr/share/libweston-14/" \
"/usr/share/libweston-14/protocols/"
mesonPackageDev "$1" \
"/usr/" "/usr/share/" \
"/usr/share/libweston-*/" \
"/usr/share/libweston-*/protocols/"

provideDeps: [ "*-tgt" ]

provideDeps: [ "*-tgt" ]
dev:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we didn't do it in the past but should we start to name the libraries explicitly? Something along the following lines?

multiPackage:
    "": # the weston binary
    libweston:
        multiPackage:
            dev: ...
            tgt: ....

I came across this in #125 where multiple libraries were provided.

@rhubert, do you have an opinion on this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may make sense with something like systemd. I am not sure if this should be a general rule. Normally all libs of a package are required. Also in this case only one lib will be installed, so there is no need in naming it explicitly. Please, also keep in mind that this may make virtual packages harder, because the target naming scheme may not be predictable anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants