Skip to content

Xcode 12 fixes #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Xcode 12 fixes #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32de3bb
fix: update iOS deployment target to 9.0 for Xcode 12
mman May 14, 2021
0ab3ceb
fix: silence XCode 12 compiler warnings
mman May 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Bolts/Common/BFTask.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

NS_ASSUME_NONNULL_BEGIN

__attribute__ ((noinline)) void warnBlockingOperationOnMainThread(void);
__attribute__ ((noinline)) void warnBlockingOperationOnMainThread() {
NSLog(@"Warning: A long-running operation is being executed on the main thread. \n"
" Break on warnBlockingOperationOnMainThread() to debug.");
Expand Down
1 change: 1 addition & 0 deletions Bolts/iOS/BFMeasurementEvent.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
NSString *const BFAppLinkNavigateOutEventName = @"al_nav_out";
NSString *const BFAppLinkNavigateBackToReferrerEventName = @"al_ref_back_out";

__attribute__((noinline)) void warnOnMissingEventName(void);
__attribute__((noinline)) void warnOnMissingEventName() {
NSLog(@"Warning: Missing event name when logging bolts measurement event. \n"
" Ignoring this event in logging.");
Expand Down
2 changes: 1 addition & 1 deletion Configurations/Bolts-iOS-Dynamic.xcconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

PRODUCT_NAME = Bolts
PRODUCT_BUNDLE_IDENTIFIER = com.bolts.ios
IPHONEOS_DEPLOYMENT_TARGET = 8.0
IPHONEOS_DEPLOYMENT_TARGET = 9.0

MODULEMAP_FILE = $(SRCROOT)/Bolts/Resources/iOS.modulemap
INFOPLIST_FILE = $(SRCROOT)/Bolts/Resources/Info.plist
Expand Down
2 changes: 1 addition & 1 deletion Configurations/Bolts-iOS.xcconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

PRODUCT_NAME = Bolts
PRODUCT_BUNDLE_IDENTIFIER = com.bolts.ios
IPHONEOS_DEPLOYMENT_TARGET = 8.0
IPHONEOS_DEPLOYMENT_TARGET = 9.0

MODULEMAP_FILE = $(SRCROOT)/Bolts/Resources/iOS.modulemap
INFOPLIST_FILE = $(SRCROOT)/Bolts/Resources/Info.plist
Expand Down
2 changes: 1 addition & 1 deletion Configurations/BoltsTests-iOS.xcconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ PRODUCT_NAME = BoltsTests-iOS
PRODUCT_MODULE_NAME = BoltsTests
PRODUCT_BUNDLE_IDENTIFIER = com.bolts.ios.tests

IPHONEOS_DEPLOYMENT_TARGET = 8.0
IPHONEOS_DEPLOYMENT_TARGET = 9.0

INFOPLIST_FILE = BoltsTests/BoltsTests-Info.plist

Expand Down