Skip to content

Conversation

@sxlijin
Copy link
Collaborator

@sxlijin sxlijin commented Sep 8, 2025

Mostly done by claude.


Important

Clean up build warnings by enforcing stricter linting rules and removing unused code across multiple Rust projects.

  • Linting:
    • Set dead_code, elided_named_lifetimes, unused_imports, and unused_variables to deny in Cargo.toml for baml-compiler, baml-lib, baml-runtime, baml_cffi_macros, boundary-udf, generators-go, generators-openapi, generators-python, generators-typescript, dir-writer, generators-lib, test-harness, baml_cffi, language-server, llm-response-parser, and zed.
  • Code Cleanup:
    • Remove unused imports and variables in jsonish/src/tests/mod.rs, runtime/mod.rs, runtime_methods/call_function.rs, and runtime_methods/stream_function.rs.
    • Remove unused functions and code blocks in language_client_cffi/build.rs and generators/languages/go/src/generated_types.rs.
  • Miscellaneous:
    • Minor changes in Cargo.toml files to align with new linting rules.

This description was created by Ellipsis for 7261470. You can customize this summary. It will automatically update as commits are pushed.

@sxlijin sxlijin temporarily deployed to boundary-tools-dev September 8, 2025 21:23 — with GitHub Actions Inactive
@sxlijin sxlijin temporarily deployed to boundary-tools-dev September 8, 2025 21:23 — with GitHub Actions Inactive
@sxlijin sxlijin temporarily deployed to boundary-tools-dev September 8, 2025 21:23 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Sep 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
promptfiddle Error Error Sep 11, 2025 2:44am

@entelligence-ai-pr-reviews
Copy link

🔒 Entelligence AI Vulnerability Scanner

No security vulnerabilities found!

Your code passed our comprehensive security analysis.


Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to cd99512 in 1 minute and 41 seconds. Click for details.
  • Reviewed 557 lines of code in 17 files
  • Skipped 0 files when reviewing.
  • Skipped posting 7 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. engine/language_client_cffi/build.rs:412
  • Draft comment:
    The cbindgen header generation block (lines 412–421) panics if there’s a diff in CI. Consider logging the differences and providing a more graceful failure, or at least a more descriptive error message for easier debugging.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. engine/language_client_cffi/src/ctypes/baml_value_with_meta_encode.rs:66
  • Draft comment:
    In the union handling in maybe_wrap_union_impl (lines 66–73), the use of unwrap_or_else with a panic may lead to abrupt termination. Consider propagating an error or handling the failure gracefully rather than panicking.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. engine/language_client_cffi/src/ffi/functions.rs:83
  • Draft comment:
    Multiple TODO comments (e.g. around line 83 and 84) note a race condition regarding the cloning of the type builder. It’s recommended to address this by making a proper deep copy to avoid concurrency issues across FFI boundaries.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. engine/generators/languages/typescript/src/type.rs:55
  • Draft comment:
    In the Checked branch of TypeWrapper (lines 55–67), the code deduplicates and sorts the names vector. This may alter the intended order of type names and affect the generated type signature. Please confirm that this behavior is as desired.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
5. engine/generators/utils/dir_writer/src/lib.rs:327
  • Draft comment:
    The remove_dir_safe function (lines 327–340) uses walkdir to iterate all files for validation. In directories with many files, this may be a performance bottleneck. Consider adding a configurable scan depth or a limit on the number of files to inspect.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
6. engine/generators/languages/typescript/src/package.rs:10
  • Draft comment:
    The Package::new function (lines 10–18) enforces that package names start with 'baml_client' or 'baml'. Verify that this constraint is appropriate for TypeScript targets or consider making it configurable to support other valid package namespaces.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
7. engine/generators/utils/dir_writer/src/lib.rs:218
  • Draft comment:
    Typographical error: In the comment, "map of path to a an object that has the trail File", consider replacing "a an" with "an". Also, "trail File" might be intended to be "tail File" or "trailing File".
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_WUGZALtlhSTEtrn2

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Comment on lines +140 to +143
struct Tracing;

pub fn render_tracing(pkg: &CurrentRenderPackage) -> Result<String, askama::Error> {
Tracing { pkg }.render()
pub fn render_tracing(_pkg: &CurrentRenderPackage) -> Result<String, askama::Error> {
Tracing.render()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correctness: render_tracing no longer passes pkg to the Tracing template, but the template struct and template may still expect it, causing runtime errors if the template references pkg.

🤖 AI Agent Prompt for Cursor/Windsurf

📋 Copy this prompt to your AI coding assistant (Cursor, Windsurf, etc.) to get help fixing this issue

In engine/generators/languages/typescript/src/functions.rs, lines 140-143, the `Tracing` struct and `render_tracing` function were changed to remove the `pkg` field and argument. However, if the Askama template for `Tracing` expects a `pkg` context variable, this will cause runtime errors. Please revert these lines so that `Tracing` is defined as `struct Tracing<'a> { pkg: &'a CurrentRenderPackage }` and `render_tracing` takes `pkg` and calls `Tracing { pkg }.render()`. Ensure the template context matches the template's requirements.
📝 Committable Code Suggestion

‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
struct Tracing;
pub fn render_tracing(pkg: &CurrentRenderPackage) -> Result<String, askama::Error> {
Tracing { pkg }.render()
pub fn render_tracing(_pkg: &CurrentRenderPackage) -> Result<String, askama::Error> {
Tracing.render()
struct Tracing<'a> {
pkg: &'a CurrentRenderPackage,
}
pub fn render_tracing(pkg: &CurrentRenderPackage) -> Result<String, askama::Error> {
Tracing { pkg }.render()
}

@github-actions
Copy link

github-actions bot commented Sep 8, 2025

@github-actions
Copy link

github-actions bot commented Sep 8, 2025

sxlijin and others added 5 commits September 8, 2025 14:31
Phase 1: Add lint configurations to 14 high-priority packages
- Added [lints.rust] sections with warn level for dead_code, elided_named_lifetimes, unused_imports, unused_variables
- Covers language generators, utilities, core libraries, and compilation tools

Phase 2: Upgrade mixed packages from allow to warn
- Upgraded 8 packages that had mixed lint settings
- Changed all "allow" entries to "warn" while preserving existing "deny" settings

Build verification: Workspace compiles successfully with expected lint warnings surfaced
Next: Catalog warnings by package and fix incrementally before upgrading to "deny"

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Phase 4 Progress: Fixed warnings and upgraded lint levels for:
- baml-compiler: Fixed 1 unused import warning, upgraded to deny
- baml_cffi: Fixed 2 warnings (build script dead code + unused variable), upgraded to deny
- internal-baml-jinja: Skipped (only 3 warnings, low priority)

Next: Continue with remaining packages in Phase 4 by warning count:
- internal-baml-codegen (6 warnings)
- internal-baml-parser-database (57 warnings)
- language-server (65 warnings)
- internal-baml-core (91 warnings)
- jsonish (218 warnings)
- baml-runtime (337 warnings)

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@github-actions
Copy link

github-actions bot commented Sep 9, 2025

@github-actions
Copy link

github-actions bot commented Sep 9, 2025

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed 8984938 in 2 minutes and 23 seconds. Click for details.
  • Reviewed 85 lines of code in 5 files
  • Skipped 0 files when reviewing.
  • Skipped posting 5 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. engine/baml-compiler/Cargo.toml:10
  • Draft comment:
    Changed lint levels to 'deny'. Ensure all warnings are fixed to avoid build errors.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the author to ensure that all warnings are fixed to avoid build errors. This falls under the rule of not asking the author to ensure behavior is intended or to double-check things. The comment does not provide a specific code suggestion or ask for a specific test to be written.
2. engine/baml-compiler/src/hir/lowering.rs:8
  • Draft comment:
    Removed unused import 'ir_type::TypeGeneric'.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, stating that an unused import was removed. It doesn't provide any actionable feedback or suggestions for improvement.
3. engine/language_client_cffi/Cargo.toml:10
  • Draft comment:
    Lint levels set to 'deny' here as well; verify this strictness is intended.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% This comment violates the rule about not asking for verification or confirmation of intended changes. The PR author deliberately changed these values from "warn" to "deny" - we should assume they did this intentionally. Additionally, if this change causes problems, it would be caught by the build process. Maybe stricter linting could cause build failures that would be disruptive to the development process, making this a valid concern worth discussing? Even if there are build failures, that's exactly what the PR author intended by making lints more strict. We should trust their judgment and let the build process validate the change. Delete this comment as it violates the rule about asking for verification of intended changes and would be caught by the build process anyway.
4. engine/language_client_cffi/build.rs:205
  • Draft comment:
    Renamed field 'version' to '_version'. Consider adding a clarifying comment if it's intentionally unused.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% The underscore prefix is a Rust convention indicating an intentionally unused field. The code change itself (adding the underscore) is the proper way to handle unused fields in Rust. Adding a comment saying "intentionally unused" would be redundant since that's exactly what the underscore prefix already communicates to Rust developers. The comment isn't suggesting a necessary code change, just documentation that duplicates what the code already clearly expresses. Perhaps there's important context about why this version field exists but isn't used that would be worth documenting? Maybe future developers would benefit from knowing the reasoning? While documentation can be helpful, the underscore prefix is a well-understood Rust convention. If there was an important reason for keeping an unused field, that would warrant a comment, but here it appears to just be implementation detail that isn't used yet. The comment should be deleted. The underscore prefix already clearly communicates that this is an intentionally unused field, making the suggested comment redundant.
5. engine/language_client_cffi/src/ffi/functions.rs:129
  • Draft comment:
    Explicitly ignore 'collectors' to avoid unused warnings; confirm no side effects are needed.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_JSpIIXgFpfDEmbsr

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Phase 4 Progress: Fixed all 6 warnings in internal-baml-codegen:
- Removed unused imports: BTreeMap, Path, Context, GeneratorDefaultClientMode, ModuleFormat, regex::Regex, sugar_path::SugarPath
- Removed unused function: version_check_with_error (both wasm32 and non-wasm32 versions)
- Removed unused version_check imports: check_version, GeneratorType, VersionCheckMode
- Upgraded lint levels from warn to deny

Successfully upgraded packages so far:
✅ baml-compiler (1 warning → deny)
✅ baml_cffi (2 warnings → deny)
✅ internal-baml-codegen (6 warnings → deny)

Remaining packages by priority:
- internal-baml-parser-database (57 warnings) - Major effort needed
- language-server (65 warnings) - Major effort needed
- internal-baml-core (91 warnings) - Major effort needed
- jsonish (218 warnings) - Extensive fixes required
- baml-runtime (337 warnings) - Most complex package

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@codecov
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ent_cffi/src/ctypes/baml_value_with_meta_encode.rs 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

sxlijin and others added 6 commits September 9, 2025 12:27
Reduced warnings from 57 to 22 with automatic fixes:
- Fixed unused imports across 17 files
- Applied 35 automatic suggestions from cargo fix
- Remaining warnings: mostly unused variables and dead code that need manual fixes

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Reduced warnings from 91 to 48 with automatic fixes:
- Fixed unused imports across 16 files
- Applied 43 automatic suggestions from cargo fix
- Remaining warnings: mostly unused variables and dead code that need manual fixes

Progress: automatic fixes applied to parser-database (57→22) and baml-core (91→48)

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@sxlijin sxlijin temporarily deployed to boundary-tools-dev September 11, 2025 01:46 — with GitHub Actions Inactive
@sxlijin sxlijin temporarily deployed to boundary-tools-dev September 11, 2025 01:46 — with GitHub Actions Inactive
@sxlijin sxlijin temporarily deployed to boundary-tools-dev September 11, 2025 01:46 — with GitHub Actions Inactive
@github-actions
Copy link

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed 030ca0b in 2 minutes and 30 seconds. Click for details.
  • Reviewed 680 lines of code in 38 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. engine/language_client_typescript/Cargo.toml:10
  • Draft comment:
    Lint config mismatch: while most crates use 'deny' for unused imports/variables, this file sets them to 'allow'. Confirm if this exception is intentional.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_1dB8JxU223LVVkon

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

description = "BAML Bytecode Compiler"
license-file.workspace = true

[lints.rust]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider centralizing these repetitive lint settings (e.g. 'deny' for dead_code, unused_imports, unused_variables) in a common workspace config to reduce duplication.

@github-actions
Copy link

@github-actions
Copy link

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed d591748 in 3 minutes and 13 seconds. Click for details.
  • Reviewed 568 lines of code in 20 files
  • Skipped 0 files when reviewing.
  • Skipped posting 17 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. engine/language_server/src/baml_project/mod.rs:1
  • Draft comment:
    Many items are now annotated with #[allow(dead_code)]. While this helps suppress warnings, consider if some unused functions could be removed entirely or if a module-level attribute might be preferable to reduce clutter. This helps avoid hiding potentially stale or unmaintained code.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
2. engine/language_server/src/baml_project/position_utils.rs:7
  • Draft comment:
    The addition of #[allow(dead_code)] on public functions (e.g. full_document_range, is_first_inside_block, etc.) may hide unused code. Consider removing unused functions or applying module-level suppression if intentional.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
3. engine/language_server/src/baml_source_file/line_ranges.rs:1
  • Draft comment:
    The allow(dead_code) attribute here suppresses warnings on the LineRanges trait and its implementations. Confirm if these methods are intended to be unused; otherwise, consider removing or testing them.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
4. engine/language_server/src/baml_source_file/mod.rs:26
  • Draft comment:
    Using #[allow(dead_code)] on publicly exposed types like SourceCode and SourceFile might obscure maintenance issues. Evaluate if they are intended for extension or should be pruned.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
5. engine/language_server/src/baml_source_file/newlines.rs:1
  • Draft comment:
    The newlines module now carries numerous #[allow(dead_code)] suppressions. Consider making some utilities private or removing them if not used.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
6. engine/language_server/src/baml_text_size/traits.rs:1
  • Draft comment:
    The trait implementations for TextLen and TextSlice are solid. The use of the Sealed pattern is effective. No changes are needed here.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
7. engine/language_server/src/cors_bypass_proxy.rs:14
  • Draft comment:
    The proxy handling code suppresses dead code warnings; ensure that any disabled methods are removed or well-documented if intended for future use.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
8. engine/language_server/src/edit/range.rs:16
  • Draft comment:
    Trait and helper functions for converting offsets and ranges are correct, but the use of blanket #[allow(dead_code)] may hide intended removals. Consider reviewing unused functions.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
9. engine/language_server/src/server.rs:3
  • Draft comment:
    The server module initialization includes several #[allow(dead_code)] and deprecated attributes. Ensure that these suppressions are temporary and consider addressing deprecation issues.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
10. engine/language_server/src/server/api/diagnostics.rs:1
  • Draft comment:
    Diagnostic publishing functions correctly clear and republish diagnostics. The error handling is consistent. No major issues here; ensure the suppressions are intentional.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
11. engine/language_server/src/server/api/requests/rename.rs:20
  • Draft comment:
    The rename handler relies on early error returns for unsupported symbols. Consider adding a TODO for implementing function renaming or notifying users about the limitation.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
12. engine/language_server/src/server/api/traits.rs:15
  • Draft comment:
    The traits for request and notification handlers are well defined. However, the repetitive use of #[allow(dead_code)] may hide functions needing refactoring. Verify that these suppressions are intentional.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
13. engine/language_server/src/server/commands.rs:7
  • Draft comment:
    The command traits for CodeLensCommand look good. The inline usage of serde_json::to_value with expect is acceptable as is. No further changes required, but monitor if serialization errors occur unexpectedly.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
14. engine/language_server/src/server/schedule/task.rs:1
  • Draft comment:
    Task scheduling types are well structured with clear distinction between background and local tasks. The commentary is useful. No changes required.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
15. engine/language_server/src/session.rs:1
  • Draft comment:
    The Session module handles project initialization and document indexing carefully. Ensure that suppressions do not hide refactoring opportunities in the future.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
16. engine/language_server/src/session/index.rs:1
  • Draft comment:
    The Index module uses FxHashMap and provides concise methods for tracking documents. Ensure that any suppressed warnings correspond to intended functionality.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
17. engine/language_server/src/session/settings.rs:1
  • Draft comment:
    The settings module cleanly deserializes client settings and global options. The defaults are well-implemented. No changes required.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_AYce1eB7GZj3fE8L

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@github-actions
Copy link

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed 37585ae in 3 minutes and 21 seconds. Click for details.
  • Reviewed 574 lines of code in 44 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. engine/zed/Cargo.toml:3
  • Draft comment:
    The package edition is set to "2024". Currently stable Rust edition is "2021". If not intentionally using a future edition, consider switching to "2021" for compatibility.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. engine/baml-lib/parser-database/Cargo.toml:12
  • Draft comment:
    Typo/lexical check: The new lint key 'mismatched_lifetime_syntaxes' seems unusual. Please verify if it is spelled as intended (e.g. should it be 'mismatched_lifetime_syntax' or 'mismatched_lifetimes')?
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% The comment is speculative and asks for verification rather than making a definitive statement. It's questioning Rust compiler lint naming which should be immediately verifiable. If the lint name was wrong, the Rust compiler would error. This is exactly the kind of thing that would be caught by the build system. Maybe this is a helpful catch of a typo before it causes build failures? Maybe saving time by catching it in review is valuable? No - our rules explicitly state not to comment on things that would be caught by the build system. The Rust compiler will immediately error if this lint name is incorrect. Delete this comment. It's speculative, asks for verification, and any lint name issues would be caught by the Rust compiler anyway.
3. engine/generators/utils/dir_writer/Cargo.toml:11
  • Draft comment:
    Typo: The new lint name "mismatched_lifetime_syntaxes" may be a typographical error. Typically, "syntax" is used as an uncountable noun, so consider if "mismatched_lifetime_syntax" was intended instead.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% This is a Rust lint configuration, and lint names are predefined by the Rust compiler. The correctness of the name depends on what the actual lint is called in Rust, not on English grammar rules. Without being able to verify the exact lint name in Rust's documentation, suggesting a name change could be misleading. The comment could be correct if there was a typo in transcribing the lint name. Rust's naming conventions do tend to follow proper English. However, lint names are fixed identifiers in Rust, and we can't verify the correct name without checking Rust's documentation. Making assumptions based on English grammar could lead to incorrect suggestions. The comment should be deleted because it makes assumptions about a system identifier based on English grammar rules without verifying the actual lint name in Rust.

Workflow ID: wflow_wbe1cVnkSA7nyTH5

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@github-actions
Copy link

@github-actions
Copy link

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed 7261470 in 3 minutes and 5 seconds. Click for details.
  • Reviewed 520 lines of code in 40 files
  • Skipped 0 files when reviewing.
  • Skipped posting 40 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. engine/baml-compiler/Cargo.toml:11
  • Draft comment:
    Replaced 'mismatched_lifetime_syntaxes' with 'elided_named_lifetimes' to clean up build warnings. This change is applied uniformly across Cargo.toml files; ensure the new lint name is supported by our Rust toolchain.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is purely informative and asks the PR author to ensure that the new lint name is supported by the Rust toolchain. This violates the rule against asking the author to ensure compatibility or correctness of the change.
2. engine/baml-ids/Cargo.toml:14
  • Draft comment:
    Updated lint from 'mismatched_lifetime_syntaxes' to 'elided_named_lifetimes'. Verify consistency with our linting policies.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is asking the PR author to verify consistency with linting policies, which falls under the category of asking for confirmation or verification. This is against the rules provided.
3. engine/baml-lib/ast/Cargo.toml:11
  • Draft comment:
    Replaced 'mismatched_lifetime_syntaxes' with 'elided_named_lifetimes'; change appears consistent with other modules.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, stating that a replacement was made and that it appears consistent with other modules. It does not provide a suggestion, ask for confirmation, or point out a potential issue.
4. engine/baml-lib/baml-core/Cargo.toml:11
  • Draft comment:
    Updated lint name to 'elided_named_lifetimes' for cleaner warnings.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, as it only states that a lint name was updated for cleaner warnings. It does not provide any actionable feedback or suggestions for improvement.
5. engine/baml-lib/baml-derive/Cargo.toml:11
  • Draft comment:
    Changed lint name from 'mismatched_lifetime_syntaxes' to 'elided_named_lifetimes'.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, as it only states what was changed without providing any suggestion, question, or request for confirmation. It doesn't align with the rules for useful comments.
6. engine/baml-lib/baml-log/Cargo.toml:14
  • Draft comment:
    Replaced 'mismatched_lifetime_syntaxes' with 'elided_named_lifetimes'.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment appears to be purely informative, as it simply states a change that was made without providing any guidance, suggestions, or questions. It does not ask for confirmation or suggest any improvements. According to the rules, purely informative comments should be removed.
7. engine/baml-lib/baml-types/Cargo.toml:11
  • Draft comment:
    Updated lint from 'mismatched_lifetime_syntaxes' to 'elided_named_lifetimes' to suppress related warnings.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, explaining a change made to suppress warnings. It doesn't provide a suggestion, ask for confirmation, or point out a potential issue. It violates the rule against making purely informative comments.
8. engine/baml-lib/baml/Cargo.toml:11
  • Draft comment:
    Replaced 'mismatched_lifetime_syntaxes' with 'elided_named_lifetimes'; change is in line with other modules.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, stating what was changed and that it aligns with other modules. It doesn't provide a suggestion, ask for confirmation, or point out a potential issue.
9. engine/baml-lib/diagnostics/Cargo.toml:11
  • Draft comment:
    Updated lint 'mismatched_lifetime_syntaxes' to 'elided_named_lifetimes'.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, stating that a lint name was updated. It doesn't provide any actionable feedback or suggestions for improvement.
10. engine/baml-lib/jinja-runtime/Cargo.toml:11
  • Draft comment:
    Changed lint from 'mismatched_lifetime_syntaxes' to 'elided_named_lifetimes'.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, as it only states what was changed without providing any suggestion, question, or potential issue related to the change. It does not ask for confirmation or suggest any action to be taken by the PR author.
11. engine/baml-lib/jinja/Cargo.toml:11
  • Draft comment:
    Replaced deprecated lint 'mismatched_lifetime_syntaxes' with 'elided_named_lifetimes'.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, stating that a deprecated lint was replaced with a new one. It doesn't provide any actionable feedback or suggestions for improvement.
12. engine/baml-lib/jsonish/Cargo.toml:11
  • Draft comment:
    Updated lint name to 'elided_named_lifetimes' from 'mismatched_lifetime_syntaxes'.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, as it only states that a lint name was updated. It does not provide any actionable feedback or suggestions for improvement.
13. engine/baml-lib/llm-client/Cargo.toml:11
  • Draft comment:
    Replaced 'mismatched_lifetime_syntaxes' with 'elided_named_lifetimes'.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment seems to be purely informative, as it only states what was changed without providing any suggestion, question, or request for confirmation. It doesn't ask for any specific action or clarification from the PR author.
14. engine/baml-lib/parser-database/Cargo.toml:11
  • Draft comment:
    Changed lint from 'mismatched_lifetime_syntaxes' to 'elided_named_lifetimes'.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, as it only states what was changed without providing any suggestion, question, or request for confirmation. It does not align with the rules for useful comments.
15. engine/baml-lib/prompt-parser/Cargo.toml:11
  • Draft comment:
    Updated lint name to 'elided_named_lifetimes' replacing 'mismatched_lifetime_syntaxes'.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, as it only states what was changed without providing any suggestion, question, or potential issue related to the change. It doesn't ask for confirmation or suggest any action to be taken by the PR author.
16. engine/baml-lsp-types/Cargo.toml:11
  • Draft comment:
    Replaced 'mismatched_lifetime_syntaxes' with 'elided_named_lifetimes' in the lint configuration.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, as it only states what was changed in the lint configuration without providing any suggestion, question, or request for confirmation. It doesn't align with the rules for useful comments.
17. engine/baml-rpc/Cargo.toml:14
  • Draft comment:
    Updated lint setting to 'elided_named_lifetimes' replacing the deprecated 'mismatched_lifetime_syntaxes'.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, as it only states what was changed without providing any actionable feedback or suggestions. It doesn't ask for confirmation or suggest any improvements.
18. engine/baml-runtime/Cargo.toml:17
  • Draft comment:
    Replaced 'mismatched_lifetime_syntaxes' with 'elided_named_lifetimes' to address build warnings.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, explaining a change made to address build warnings. It does not provide a suggestion, ask for confirmation, or highlight a potential issue.
19. engine/baml-schema-wasm/Cargo.toml:15
  • Draft comment:
    Changed lint from 'mismatched_lifetime_syntaxes' to 'elided_named_lifetimes'.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, as it only states what was changed without providing any suggestion, question, or request for confirmation. It does not align with the rules for useful comments.
20. engine/baml_cffi_macros/Cargo.toml:8
  • Draft comment:
    Updated lint configuration: replaced 'mismatched_lifetime_syntaxes' with 'elided_named_lifetimes'.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, as it only describes a change in the lint configuration without providing any actionable feedback or suggestions. It does not ask for confirmation or suggest any improvements.
21. engine/boundary-udf/Cargo.toml:8
  • Draft comment:
    Replaced 'mismatched_lifetime_syntaxes' with 'elided_named_lifetimes' for consistent linting.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, explaining a change made in the code without suggesting any action or asking for clarification. It doesn't provide any specific guidance or raise any issues that need to be addressed.
22. engine/bstd/Cargo.toml:14
  • Draft comment:
    Updated lint from 'mismatched_lifetime_syntaxes' to 'elided_named_lifetimes'; change is consistent with our other modules.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, explaining a change in lint settings. It doesn't provide a suggestion, ask for confirmation, or highlight a potential issue.
23. engine/cli/Cargo.toml:17
  • Draft comment:
    Replaced 'mismatched_lifetime_syntaxes' with 'elided_named_lifetimes' to resolve build warnings.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, explaining a change made to resolve build warnings. It does not provide a suggestion, ask for confirmation, or highlight a potential issue.
24. engine/generators/languages/go/Cargo.toml:10
  • Draft comment:
    Updated lint setting to 'elided_named_lifetimes' instead of 'mismatched_lifetime_syntaxes'.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, as it only states what was changed without providing any suggestion, question, or issue related to the change. It doesn't ask for confirmation or suggest any action to be taken.
25. engine/generators/languages/openapi/Cargo.toml:10
  • Draft comment:
    Changed lint from 'mismatched_lifetime_syntaxes' to 'elided_named_lifetimes'.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, as it only states what was changed without providing any suggestion, question, or potential issue related to the change. It does not ask for confirmation or suggest any action to be taken by the PR author.
26. engine/generators/languages/python/Cargo.toml:10
  • Draft comment:
    Replaced 'mismatched_lifetime_syntaxes' with 'elided_named_lifetimes'.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative as it only states what was changed without providing any suggestion, question, or request for confirmation. It doesn't ask for any action or provide any insight into whether the change is correct or needs further attention.
27. engine/generators/languages/ruby/Cargo.toml:10
  • Draft comment:
    Updated lint name from 'mismatched_lifetime_syntaxes' to 'elided_named_lifetimes'; note that dead_code and unused_imports are set to 'allow' here as per project policy.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, providing details about a change in lint names and project policy regarding certain lints. It does not suggest any code changes or ask for specific confirmations related to the code's functionality.
28. engine/generators/languages/typescript/Cargo.toml:11
  • Draft comment:
    Replaced deprecated lint 'mismatched_lifetime_syntaxes' with 'elided_named_lifetimes'.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, as it only states what was changed without providing any suggestion or asking for confirmation. It doesn't ask for any action or provide any insight beyond stating the change.
29. engine/generators/utils/dir_writer/Cargo.toml:10
  • Draft comment:
    Updated lint configuration to use 'elided_named_lifetimes' in place of 'mismatched_lifetime_syntaxes'.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, as it only states what was changed in the lint configuration without providing any suggestions or asking for confirmation on specific changes. It doesn't align with the rules for useful comments.
30. engine/generators/utils/generators_lib/Cargo.toml:10
  • Draft comment:
    Replaced 'mismatched_lifetime_syntaxes' with 'elided_named_lifetimes' for consistent linting.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, explaining a change made in the code without suggesting any action or asking for clarification. It doesn't provide any specific guidance or raise any issues that need to be addressed.
31. engine/generators/utils/test_harness/Cargo.toml:10
  • Draft comment:
    Updated lint from 'mismatched_lifetime_syntaxes' to 'elided_named_lifetimes' to avoid build warnings.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, explaining a change made to avoid build warnings. It doesn't provide a suggestion, ask for confirmation, or highlight a potential issue.
32. engine/language_client_cffi/Cargo.toml:10
  • Draft comment:
    Replaced 'mismatched_lifetime_syntaxes' with 'elided_named_lifetimes' in lint settings.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, as it only states what was changed in the code without providing any suggestion, question, or request for confirmation. It doesn't align with the rules for useful comments.
33. engine/language_client_codegen/Cargo.toml:10
  • Draft comment:
    Updated lint configuration: using 'elided_named_lifetimes' instead of 'mismatched_lifetime_syntaxes'.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, as it only states a change in the lint configuration without providing any actionable feedback or suggestions. It doesn't ask for confirmation or suggest any improvements.
34. engine/language_client_python/Cargo.toml:14
  • Draft comment:
    Replaced deprecated lint 'mismatched_lifetime_syntaxes' with 'elided_named_lifetimes'.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, stating a change from one lint to another. It doesn't provide any actionable feedback or suggestions for improvement.
35. engine/language_client_ruby/ext/ruby_ffi/Cargo.toml:16
  • Draft comment:
    Changed lint from 'mismatched_lifetime_syntaxes' to 'elided_named_lifetimes' for consistency, while keeping 'dead_code' and others at 'allow' as per Ruby bindings policy.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, explaining a change in lint settings. It doesn't provide a suggestion, ask for confirmation, or highlight a potential issue. It seems to violate the rule against making purely informative comments.
36. engine/language_client_typescript/Cargo.toml:11
  • Draft comment:
    Replaced 'mismatched_lifetime_syntaxes' with 'elided_named_lifetimes' to clean up lint warnings.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, explaining a change made to clean up lint warnings. It doesn't provide a suggestion, ask for confirmation, or point out a potential issue.
37. engine/language_server/Cargo.toml:10
  • Draft comment:
    Updated lint setting to 'elided_named_lifetimes' replacing 'mismatched_lifetime_syntaxes'.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, as it only states what was changed without providing any suggestion, question, or issue related to the change. It doesn't ask for confirmation or suggest any improvements.
38. engine/llm-response-parser/Cargo.toml:10
  • Draft comment:
    Replaced 'mismatched_lifetime_syntaxes' with 'elided_named_lifetimes' for consistent linting.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, as it only describes a change made in the code without providing any actionable feedback or suggestions. It doesn't ask for confirmation or suggest any improvements.
39. engine/playground-server/Cargo.toml:10
  • Draft comment:
    Updated lint configuration: replaced 'mismatched_lifetime_syntaxes' with 'elided_named_lifetimes'.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, as it only describes a change in the lint configuration without providing any actionable feedback or suggestions. It doesn't ask for confirmation or suggest any improvements.
40. engine/zed/Cargo.toml:8
  • Draft comment:
    Replaced 'mismatched_lifetime_syntaxes' with 'elided_named_lifetimes' to align with updated lint policies.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, explaining a change made to align with updated lint policies. It doesn't provide a suggestion, ask for confirmation, or point out a potential issue.

Workflow ID: wflow_tEIpelS0JHR5RH6v

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants