-
Notifications
You must be signed in to change notification settings - Fork 209
Release 6.7.0 #1066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 6.7.0 #1066
Conversation
Summary By MatterAI
🔄 What ChangedThis Pull Request updates the
Additionally, the 🔍 Impact of the ChangeThis update provides users of the 📁 Total Files Changed4 files were modified in this pull request:
🧪 Test AddedNo explicit new tests or test files were added as part of this pull request. The PR body includes an empty "Testing Instructions" section, indicating that specific testing steps for this release were not provided within the PR description. 🔒Security VulnerabilitiesNo new security vulnerabilities were introduced or detected in the code changes within this pull request. The update to newer SDK versions may implicitly include security fixes from the Branch SDKs themselves, but this PR's code changes do not introduce any new vulnerabilities. Caution Package Vulnerabilities
Tip Quality Recommendations
Sequence DiagramsequenceDiagram
actor Maintainer
participant PR as Pull Request
participant RNBranchRepo as react-native-branch Repository
participant AndroidSDK as Branch Android SDK
participant iOSSDK as Branch iOS SDK
Maintainer->>PR: Initiates "Release 6.7.0" PR
PR->>RNBranchRepo: Updates package.json (version 6.6.0 -> 6.7.0)
PR->>RNBranchRepo: Updates android/build.gradle (Android SDK 5.16.1 -> 5.18.0)
PR->>RNBranchRepo: Updates react-native-branch.podspec (iOS SDK 3.10.0 -> 3.12.1)
PR->>RNBranchRepo: Updates ChangeLog.md (Adds 6.7.0 release notes)
RNBranchRepo-->>AndroidSDK: Consumes new Android SDK version 5.18.0
RNBranchRepo-->>iOSSDK: Consumes new iOS SDK version 3.12.1
PR->>Maintainer: Ready for review and merge
Maintainer->>RNBranchRepo: Merges PR
RNBranchRepo->>RNBranchRepo: New version 6.7.0 published
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good overall. It's a straightforward version update for the Branch SDKs on both platforms. I have one minor suggestion to ensure version consistency.
implementation 'androidx.localbroadcastmanager:localbroadcastmanager:1.0.0' | ||
implementation 'com.facebook.react:react-native:+' // From node_modules | ||
api 'io.branch.sdk.android:library:5.16.1' | ||
api 'io.branch.sdk.android:library:5.18.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Code Refactor
Issue: The Android SDK version in build.gradle (5.18.0) doesn't exactly match the version mentioned in the changelog (5.18.1).
Fix: Update the Android SDK version to match the changelog entry for consistency.
Impact: Ensures version consistency across documentation and implementation, preventing potential confusion.
api 'io.branch.sdk.android:library:5.18.0' | |
api 'io.branch.sdk.android:library:5.18.1' |
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
Reference
SDK-XXXX -- <TITLE>.
Summary
Motivation
Type Of Change
Testing Instructions
cc @BranchMetrics/saas-sdk-devs for visibility.