Skip to content

Conversation

gdeluna-branch
Copy link
Contributor

Reference

SDK-XXXX -- <TITLE>.

Summary

Motivation

Type Of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing Instructions

cc @BranchMetrics/saas-sdk-devs for visibility.

Copy link

matter-code-review bot commented May 21, 2025

Code Quality new feature

Summary By MatterAI MatterAI logo

🔄 What Changed

This Pull Request updates the react-native-branch package version from 6.6.0 to 6.7.0. The core changes involve bumping the underlying native Branch SDK dependencies:

  • Android SDK: Updated from 5.16.1 to 5.18.0 in android/build.gradle.
  • iOS SDK: Updated from 3.10.0 to 3.12.1 in react-native-branch.podspec.

Additionally, the ChangeLog.md file has been updated to document these version bumps and the release of 6.7.0.

🔍 Impact of the Change

This update provides users of the react-native-branch library with the latest features, bug fixes, and performance improvements available in the newer versions of the native Branch Android and iOS SDKs. This is primarily a maintenance release for the React Native wrapper, ensuring compatibility and access to the latest native SDK capabilities. It is expected to be a non-breaking change for the react-native-branch wrapper itself, though users should review the release notes of the underlying Branch SDKs for any potential breaking changes or migration steps.

📁 Total Files Changed

4 files were modified in this pull request:

  • ChangeLog.md
  • android/build.gradle
  • package.json
  • react-native-branch.podspec

🧪 Test Added

No explicit new tests or test files were added as part of this pull request. The PR body includes an empty "Testing Instructions" section, indicating that specific testing steps for this release were not provided within the PR description.

🔒Security Vulnerabilities

No new security vulnerabilities were introduced or detected in the code changes within this pull request. The update to newer SDK versions may implicitly include security fixes from the Branch SDKs themselves, but this PR's code changes do not introduce any new vulnerabilities.

Caution

Package Vulnerabilities

Package Version Severity CVE Fix Version Vulnerability
react-native >= 0.60 HIGH CVE-2020-1920 0.62.3 Regular expression denial
of service
in react-native
@babel/runtime ^7.20.0 MODERATE CVE-2025-27789 7.26.10 Babel has inefficient
RegExp complexity
in generated
code with
.replace when
transpiling named
capturing groups

Tip

Quality Recommendations

  1. The Pull Request body's 'Summary', 'Motivation', and 'Testing Instructions' sections are left as empty templates. For a release PR, it is crucial to provide a clear summary of the changes, the motivation behind them (e.g., what new features or fixes the updated SDKs bring), and detailed testing instructions to ensure the stability of the new release. Filling these out would significantly improve the PR's clarity and reviewability.

  2. Consider adding automated checks or a more structured release process to ensure all necessary files (like ChangeLog.md) are consistently updated and that the underlying SDK release notes are reviewed for any breaking changes that might impact users of react-native-branch.

Sequence Diagram

sequenceDiagram
    actor Maintainer
    participant PR as Pull Request
    participant RNBranchRepo as react-native-branch Repository
    participant AndroidSDK as Branch Android SDK
    participant iOSSDK as Branch iOS SDK

    Maintainer->>PR: Initiates "Release 6.7.0" PR
    PR->>RNBranchRepo: Updates package.json (version 6.6.0 -> 6.7.0)
    PR->>RNBranchRepo: Updates android/build.gradle (Android SDK 5.16.1 -> 5.18.0)
    PR->>RNBranchRepo: Updates react-native-branch.podspec (iOS SDK 3.10.0 -> 3.12.1)
    PR->>RNBranchRepo: Updates ChangeLog.md (Adds 6.7.0 release notes)
    RNBranchRepo-->>AndroidSDK: Consumes new Android SDK version 5.18.0
    RNBranchRepo-->>iOSSDK: Consumes new iOS SDK version 3.12.1
    PR->>Maintainer: Ready for review and merge
    Maintainer->>RNBranchRepo: Merges PR
    RNBranchRepo->>RNBranchRepo: New version 6.7.0 published
Loading

Copy link

@matter-code-review matter-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good overall. It's a straightforward version update for the Branch SDKs on both platforms. I have one minor suggestion to ensure version consistency.

implementation 'androidx.localbroadcastmanager:localbroadcastmanager:1.0.0'
implementation 'com.facebook.react:react-native:+' // From node_modules
api 'io.branch.sdk.android:library:5.16.1'
api 'io.branch.sdk.android:library:5.18.0'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Code Refactor

Issue: The Android SDK version in build.gradle (5.18.0) doesn't exactly match the version mentioned in the changelog (5.18.1).
Fix: Update the Android SDK version to match the changelog entry for consistency.
Impact: Ensures version consistency across documentation and implementation, preventing potential confusion.

Suggested change
api 'io.branch.sdk.android:library:5.18.0'
api 'io.branch.sdk.android:library:5.18.1'

Copy link

Important

PR Review Skipped

PR review skipped as per the configuration setting. Run a manually review by commenting /matter review

💡Tips to use Matter AI

Command List

  • /matter summary: Generate AI Summary for the PR
  • /matter review: Generate AI Reviews for the latest commit in the PR
  • /matter review-full: Generate AI Reviews for the complete PR
  • /matter release-notes: Generate AI release-notes for the PR
  • /matter : Chat with your PR with Matter AI Agent
  • /matter remember : Generate AI memories for the PR
  • /matter explain: Get an explanation of the PR
  • /matter help: Show the list of available commands and documentation
  • Need help? Join our Discord server: https://discord.gg/fJU5DvanU3

@gdeluna-branch gdeluna-branch merged commit 1ffa7a8 into master May 21, 2025
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants