Adding river deltas. Algorithm needs to be checked #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't mean to push this IsLake algorithm to this PR, but it should be fine. It kind of fits. It's mostly needed for #430, but hopefully these can both be added in fairly short order |
|
This looks awesome! It would be great if you could look into rebasing onto #407, since we are in the process of updating the tile rendering to use Godot's TileMap class. The logic for choosing which tiles to render deltas on / which delta texture to use should be the same, but you'd need to add some code to load the delta pcx into a tile atlas and then index into that and add it to the tilemap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #107. Deltas seem to work
Looks good
This issue is probably unrelated.
This might be an issue.