Award the bonus shield to an industrial civ metropolis #760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomWerner
force-pushed
the
twrner/industrious-metropolis-shield
branch
from
f2e095f to
30c665e
Compare
esbudylin
reviewed
Jun 21, 2025
| yield += 2; | ||
|
|
||
| // TODO: +1 more for industrial civs. | ||
| // Industrious civs get +1 production in metropolises |
There was a problem hiding this comment.
I don't think this is the right way to implement tile yield bonuses for civ traits. I think that for future moddability, we should implement it similarly to the tileModifier fields in the Government and Building classes. This approach will make it easier to separate this logic in user scripts later. However, it will likely require refactoring civ traits from an enum to a class.
TomWerner
force-pushed
the
twrner/industrious-metropolis-shield
branch
from
30c665e to
060be40
Compare
pcen
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also replaced some hardcoded constants with the relevant rules.