Create Hikes immediately #83
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nb9960
reviewed
Jan 23, 2022
Comment on lines
224
to
227
| if (model.startsAt.isBefore(DateTime.now() | ||
| .subtract(Duration(minutes: 1)))) { | ||
| navigationService | ||
| .showSnackBar("Enter a valid date and time!"); |
There was a problem hiding this comment.
Instead of snack bar, I guess it would be better to add validations in the fields itself. When keyboard is on snackbar popups aren't displayed well.
There was a problem hiding this comment.
Ok! So should I close the keyboard upon this error and then show snackbar or validate the field itself?
There was a problem hiding this comment.
Validating fields would be better.
There was a problem hiding this comment.
Any progress? @ItsAdityaKSingh
There was a problem hiding this comment.
Not quite! Got busy in academics. Gonna run through the required changes requested and update soon :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82
Describe the changes you have made in this PR - Reduced a minute for creating hike immediately. Also changed a snack bar message
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.