Skip to content

Conversation

tpadioleau
Copy link
Member

No description provided.

@tpadioleau tpadioleau requested a review from EmilyBourne July 22, 2025 09:12
@tpadioleau tpadioleau self-assigned this Jul 22, 2025
@tpadioleau tpadioleau linked an issue Jul 22, 2025 that may be closed by this pull request
Copy link
Collaborator

@EmilyBourne EmilyBourne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test should be added. This is important because the test will probably show that this change is not sufficient. In #892 I additionally had to add strided_discrete_domain to the includes

@tpadioleau tpadioleau force-pushed the 891-cant-slice-a-chunkspan-defined-on-a-strideddiscretedomain branch from ca3e616 to efde399 Compare July 22, 2025 09:28
@tpadioleau
Copy link
Member Author

tpadioleau commented Jul 22, 2025

A test should be added. This is important because the test will probably show that this change is not sufficient. In #892 I additionally had to add strided_discrete_domain to the includes

True, I fixed it. It seems that the compiler did not encounter the correct overload of select before operator[]. I think there are two solutions:

  • either use ADL with using ddc::select inside the function
  • either use the Rebind type alias that is now part of the mandatory API of domains.

Copy link

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.02%. Comparing base (0c112d9) to head (7319f84).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #893      +/-   ##
==========================================
+ Coverage   94.00%   94.02%   +0.01%     
==========================================
  Files          55       55              
  Lines        2718     2727       +9     
  Branches      853      854       +1     
==========================================
+ Hits         2555     2564       +9     
  Misses         87       87              
  Partials       76       76              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

EmilyBourne
EmilyBourne previously approved these changes Jul 22, 2025
@tpadioleau tpadioleau force-pushed the 891-cant-slice-a-chunkspan-defined-on-a-strideddiscretedomain branch from a14f93c to 7319f84 Compare July 22, 2025 14:05
@tpadioleau tpadioleau merged commit 9fb1d13 into main Jul 22, 2025
125 of 126 checks passed
@tpadioleau tpadioleau deleted the 891-cant-slice-a-chunkspan-defined-on-a-strideddiscretedomain branch July 22, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't slice a ChunkSpan defined on a StridedDiscreteDomain
2 participants