Skip to content

firewall: wait for PHY IRQ before starting stack #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

firewall: wait for PHY IRQ before starting stack #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions lib/firewall/firewall.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1186,6 +1186,22 @@ bool ethernet_driver_start(std::atomic<uint8_t> *state)
auto &ethernet = lazy_network_interface();
ethernet.mac_address_set(mac_address());
initialize_dns_resolver(firewall_mac_address_get());

/*
* If the interface link isn't ready, wait for any IRQ. Acknowledging
* it can't hurt, since the driver's thread's about to go poll for frames.
*/
{
uint32_t firstInterrupt = ethernet.receive_interrupt_value();
if (!ethernet.phy_link_status())
{
Debug::log("Link not ready; wait for first IRQ");
Timeout t{UnlimitedTimeout};
ethernet.receive_interrupt_complete(&t, firstInterrupt);
Debug::log("Link ready? {}", ethernet.phy_link_status());
}
}

// Poke the barrier and make the driver thread start.
barrier = 2;
barrier.notify_one();
Expand Down