-
Notifications
You must be signed in to change notification settings - Fork 56
Project 3: Charles Wang #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aczw
wants to merge
147
commits into
CIS5650-Fall-2025:main
Choose a base branch
from
aczw:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repo Link
aczw/cuda-path-tracer
Core Features Completed
Extended Features Completed
Other Features and Details
More detail can be found in the README. However, here's a brief list of changes that you should probably be aware of:
std::format
, MSVC doesn't seem to like those.FILE
key from theCamera
object because it now simply uses the JSON file name.stb_image
andstb_image_write
header files becausetiny_gltf
required it. Also, I addedtiny_gltf
as a library.README Completion Checklist
Late Days Used
I used 4 late days for the code submission.
Project feedback
I think a lot of the base code was difficult to work with. I spent the first few days rewriting the code so that I could get a better understanding of how the libraries were set up, and ultimately it helped me add new features much more easily and quickly.