[OpenWrt] Fix hostname detection #1602
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first step to fix error on OpenWrt without changing current behavior.
OpenWrt can be run on devices with little resource, so it can miss some BusyBox commands (eg. hostname). The standard way of gathering info about OpenWrt is by the `uci` command, see: <https://openwrt.org/docs/guide-user/base-system/uci>.
To save resources, BusyBox for OpenWrt is compiled without support for character classes in `tr` command (FEATURE_TR_CLASSES). In that case `tr` treats `[:alnum:]` like a group of single characters, so it misses all numbers and most of letters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of enabling support for OpenWrt, see: #1600.
(more details in commit messages)