Skip to content

Do Not Allow N/A as Product or Vendor #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Do Not Allow N/A as Product or Vendor #399

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f443b63
Do Not Allow N/A
jgamblin Apr 9, 2025
1fdadbe
Update CVE_Record_Format.json
jgamblin Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions schema/CVE_Record_Format.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,13 +125,15 @@
"type": "string",
"description": "Name of the organization, project, community, individual, or user that created or maintains this product or hosted service. Can be 'N/A' if none of those apply. When collectionURL and packageName are used, this field may optionally represent the user or account within the package collection associated with the package.",
"minLength": 1,
"maxLength": 512
"maxLength": 512,
"pattern": "^(?!(n\/a)$).*"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this regular expression isn't quite right (see here, it fails to match n/a). I believe it should be ^\s*[nN]\/[aA]\s*$ (see here, it matches all intended test cases).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, I was wrong. I forgot the regex needs to be negated.

Here is a corrected one: ^(?!(\s*[nN]\/[aA])\s*$).* (with explanation)

},
"product": {
"type": "string",
"description": "Name of the affected product.",
"minLength": 1,
"maxLength": 2048
"maxLength": 2048,
"pattern": "^(?!(n\/a)$).*"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same regular expression comment as my other one.

},
"collectionURL": {
"description": "URL identifying a package collection (determines the meaning of packageName).",
Expand Down