Skip to content

Anchor CPE patterns #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Anchor CPE patterns #401

wants to merge 1 commit into from

Conversation

tschmidtb51
Copy link

fixes #400

@ccoffin ccoffin changed the base branch from main to develop May 20, 2025 16:18
ccoffin
ccoffin reviewed May 20, 2025
View reviewed changes
Copy link
Collaborator

@ccoffin ccoffin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that the upper cpe22and23 pattern match might need a tweak. Note that it contains a match for both cpe 2.2 and cpe 2.3. I included the anchors for both and now it appears to work as i would suspect. I am not a regex guru so let me know if i am missing something. See https://regex101.com/r/KluW0Y/1 for the updated pattern match.

@tschmidtb51
Copy link
Author

@ccoffin If I didn't miss anything, then you changed it from ^((cpe2.2)|(cpe2.3))$ to ^(cpe2.2)$|^(cpe2.3)$. IMHO both are equivalent...

CSAF uses the following (which IIRC just swaps the CPE versions):
https://github.com/oasis-tcs/csaf/blob/1726fcf10d6e444e6e65a696ac9198c981858d23/csaf_2.1/json_schema/csaf_json_schema.json#L163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccoffin ccoffin ccoffin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CPE patterns are not anchored
2 participants
@tschmidtb51 @ccoffin