Misc. Record Format fixes #450
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a type defined in the schema but never actually used. As such, its removal doesn't break anything. Fixes: CVEProject#353 Fixes: CVEProject#288 Signed-off-by: Andrew Lilley Brinker <[email protected]>
Sub-seconds are a level of fidelity beyond what's needed for CVE Records, and in practice are rarely used. Timezones are essential for correctly interpreting time data, and rather than defaulting to a (likely wrong) assumption that without a timezone a timestamp is in UTC (or GMT) we should require timezones at submission. Fixes: CVEProject#353 Fixes: CVEProject#314 Fixes: CVEProject#289 Signed-off-by: Andrew Lilley Brinker <[email protected]>
This amends the schema's own self-description to be clearer. Signed-off-by: Andrew Lilley Brinker <[email protected]>
Adds a boolean field to indicate when a description is preformatted, meaning its formatting should be preserved when it is displayed, if possible. Fixes: CVEProject#341 Signed-off-by: Andrew Lilley Brinker <[email protected]>
This fills out the previously-broken "source" field, which was intended to be adapted from Vulnogram, by completing the adaptation. See: https://github.com/Vulnogram/Vulnogram/blob/de7a77c20d849222f748922c55a5c2bc3503e14c/default/cve5/cve5.schema.json#L3180-L3250 Fixes: CVEProject#339 Fixes: CVEProject#317 Signed-off-by: Andrew Lilley Brinker <[email protected]>
There are currently several date fields which are filled out by CVE Services generally, but which aren't officially required, and where some records slip through which do not include them. Fixes: CVEProject#334 Signed-off-by: Andrew Lilley Brinker <[email protected]>
This updates the Markdown formatting of `versions.md` to correctly follow the Markdown spec, including correct spacing of lists. It also wraps all code blocks and ASCII diagrams in backticks to preserve formatting. Signed-off-by: Andrew Lilley Brinker <[email protected]>
Based on feedback in [1]. [1]: CVEProject#280 Signed-off-by: Andrew Lilley Brinker <[email protected]>
Signed-off-by: Andrew Lilley Brinker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #449, I wanted to see how many of the open bugs would be easy to fix. It turns out many are!
To review these commits, I recommend reviewing them commit-by-commit.
This fixes the following:
These are the kinds of things I would push for prioritizing in a 6.0.0 release.