Enhancements to QThreadExecutor #152
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristjanvalur
force-pushed
the
pool2
branch
2 times, most recently
from
d79c72e to
9d176df
Compare
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||
kristjanvalur
force-pushed
the
pool2
branch
2 times, most recently
from
601687c to
c6807c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the conformity of QThreadExecutor with the Executor protocol.
shutdown()is now thread-safe and there is no race betweenshutdown()andsubmit().shutdown()can be called more than once. This is how the standard Executors work, and is congruent withclose()and similar methods.map()is supported.cancel_futuresargument toshutdown()is supported.