Added support for dark mode and a couple other things. #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axhan
commented
Apr 8, 2022
axhan
commented
…e was made the default. Support was added for application-wide dark or light mode using qdarkstyle through qt stylesheets. The stylesheet doesn't affect the console component background colour, so I made it set light or dark background styles using its own, separate Jupyter styling according to the app theme. (The code editor's colours are alse immune to the stylesheet, but I left it untouched since its preferences-selectable syntax color schemes already include schemes with both light and dark backgrounds. The 3D viewer's colours are also impervious to stylesheets, I likewise left it untouched since its colours are already fully adjustable in the preferences). A command-line option '-r, --restore_defaults' to delete the file containing stored preferences was added. All instantiations of QApplication except one were made conditional on it not already having been instantiated.
Contributor
|
You might want to add |
Member
|
@axhan If you are still interested in advancing this PR, would you be able to scope it to just the dark theme changes? There seem to be a lot of unrelated changes in the log. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.