-
-
Notifications
You must be signed in to change notification settings - Fork 97
Graphical Overhaul Pt.1 #607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Assets/__Scenes/03_Mapper.unity # Assets/__Scripts/Platforms/Basic/TrackLaneRingsManagerBase.cs
Collaborator
# Conflicts: # Assets/__Scenes/03_Mapper.unity # Assets/__Scripts/MapEditor/Grid/BookmarkRenderingController.cs
d969404 to
a7e60e4
Compare
Owner
|
aight lets do this thing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.




To properly support current and future content of Beat Saber, a switch from URP to BiRP may be a necessity. This includes bloom behaviour changes. Require thorough exploration and checks. As for now, PR target is to have graphical parity as previous URP. Next part would be to implement Beat Saber-like shader including bloom fog.
What does this bring:
To do:
Known issue:
cmbirp3.1.mp4