Skip to content

Component update optimisation #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 4, 2025
Merged

Component update optimisation #610

merged 6 commits into from
Oct 4, 2025

Conversation

KivalEvan
Copy link
Contributor

@KivalEvan KivalEvan commented Sep 30, 2025 •
edited
Loading

Yet another PR, this time to address unnecessarily expensive component update:

  • Measure line and bookmark rendering controller now keep track of active object rather than checking every object and setting valid active.
    • Stops updating when preview mode is on.
  • Song timeline controller stop updating when playback in non-normal UI mode, partially because timeline is completely hidden. Text and slider update is expensive even if it's not being shown.
  • Since these are time dependent, it is only updated only when time changed in ATSC.

This resulted in component updating up to 3-10x faster.

squash commit thx

Caeden117
Caeden117 approved these changes Oct 4, 2025
View reviewed changes
Copy link
Owner

@Caeden117 Caeden117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, will test tomorrow alongside #608

@XAce1337manX XAce1337manX merged commit c3e7fea into Caeden117:dev Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Caeden117 Caeden117 Caeden117 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KivalEvan @Caeden117 @XAce1337manX