Skip to content

Conversation

ProLoser
Copy link
Member

Was looking at the fork graph and noticed @bmilesp has quite a bit of work on this plugin.

Perhaps we should merge this in and he would be interested in joining the contributors?

@bmilesp
Copy link

bmilesp commented Aug 30, 2013

Sounds great. I also have plugins that extend this version of Copula (Shopify, Vend, and Linkpoint) That i'm planning to make repos here for as well. Would be nice to have them working out of the box with the master project.

We currently work with a lot of APIs so i have no doubt we will continue to build onto this in the long term, as well as add plugins that extend it. -bp

@ProLoser
Copy link
Member Author

@tenebrousedge you still around these days?

@@ -96,7 +97,7 @@ public function getHttpObject($authMethod, $url = null) {
* @param \Model $model
* @return mixed
*/
public function describe(\Model $model) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious about the reason for this?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Cakephp 2.4.0-beta and php 5.4.3 the typecast was throwing an error so i removed it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See here for details. Apparently that now may also take a string as the argument.

@tenebrousedge
Copy link
Member

This all is really quite interesting. It should be split up into several patch sets, though. The multiple-domain changes are probably a strong candidate for being a feature, and the code related to ApisSource::_getPath() also merits consideration. The formatting thing is also very interesting although I am not sure about what the default behavior should be. I am initially inclining towards the idea that this is a lot of data-wrangling for this class to do, and that ferreting out the request structure should be handled in some other class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants