-
Notifications
You must be signed in to change notification settings - Fork 22
Merge bmilesp fork #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…se[Modelname] format)
…g the same api keys
…ed login password posts for linkpoint
… function for manual content type application
… function for manual content type application
Sounds great. I also have plugins that extend this version of Copula (Shopify, Vend, and Linkpoint) That i'm planning to make repos here for as well. Would be nice to have them working out of the box with the master project. We currently work with a lot of APIs so i have no doubt we will continue to build onto this in the long term, as well as add plugins that extend it. -bp |
@tenebrousedge you still around these days? |
@@ -96,7 +97,7 @@ public function getHttpObject($authMethod, $url = null) { | |||
* @param \Model $model | |||
* @return mixed | |||
*/ | |||
public function describe(\Model $model) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious about the reason for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Cakephp 2.4.0-beta and php 5.4.3 the typecast was throwing an error so i removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See here for details. Apparently that now may also take a string as the argument.
This all is really quite interesting. It should be split up into several patch sets, though. The multiple-domain changes are probably a strong candidate for being a feature, and the code related to |
Was looking at the fork graph and noticed @bmilesp has quite a bit of work on this plugin.
Perhaps we should merge this in and he would be interested in joining the contributors?