Skip to content

Prepare sourceCall by scheme #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.6
Choose a base branch
from
Open

Prepare sourceCall by scheme #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cascading-core/src/main/java/cascading/tuple/TupleEntrySchemeIterator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ private TupleEntry getNext() throws IOException
if( !hasWaiting && inputIterator.hasNext() )
{
sourceCall.setInput( wrapInput( inputIterator.next() ) );
scheme.sourcePrepare( flowProcess, sourceCall );
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there going to be a big hit to call this each time? Is this the right fix vs in elephantbird?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will hit only once we switch between recordReaders.

Unfortunately, it's impossible to fix in every possible recordRead. many of them written in the same way which used in ElephantBird. I think it's a problem with "elegant" design of recordReader in hadoop, createKey and createValue creates mutable objects which passed to method next which supposed to mutate them.


return getNext();
}
Expand Down