Skip to content

Conversation

@antkryt
Copy link
Contributor

@antkryt antkryt commented Aug 8, 2025

Purpose

return only distinct moderators

Changes

QA Notes

Documentation

Side Effects

Ticket

https://openscience.atlassian.net/browse/ENG-8522

@antkryt
Copy link
Contributor Author

antkryt commented Aug 8, 2025

tests passed on my local branch, please rerun tests here

@adlius adlius changed the base branch from develop to feature/pbs-25-16 August 13, 2025 13:35
@adlius adlius changed the base branch from feature/pbs-25-16 to feature/pbs-25-19 September 18, 2025 05:19
@adlius adlius deleted the branch CenterForOpenScience:feature/pbs-25-21 October 16, 2025 13:17
@adlius adlius closed this Oct 16, 2025
@adlius adlius reopened this Oct 23, 2025
@adlius adlius changed the base branch from feature/pbs-25-19 to feature/pbs-25-21 October 23, 2025 15:54
@adlius
Copy link
Collaborator

adlius commented Oct 23, 2025

@antkryt Could you give a brief explanation about the issue and how changing the query would fix that? I am a bit confused.

@antkryt
Copy link
Contributor Author

antkryt commented Oct 24, 2025

@adlius as far as I remember the problem was on the FE side (cosmetic). Backend returned users that are both admins and moderators return admin_group.user_set.all() | mod_group.user_set.all() and FE (ember) didn't know which one to display, admin or moderator role. My fix returns only distinct users with role "admin" if user is admin and "moderator" otherwise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants