Skip to content

[ENG-8988] update draft registration URL to use angular route #11393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2025
+2 −2
Merged

[ENG-8988] update draft registration URL to use angular route #11393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9150fbe
update draft registration URL to use angular route
Ostap-Zherebetskyi Oct 24, 2025
4896055
fix unit test
Ostap-Zherebetskyi Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion osf/models/registrations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1019,7 +1019,7 @@ class DraftRegistration(ObjectIDMixin, RegistrationResponseMixin, DirtyFieldsMix
'node_license',
]

URL_TEMPLATE = settings.DOMAIN + 'registries/drafts/{draft_id}'
URL_TEMPLATE = settings.DOMAIN + 'registries/drafts/{draft_id}/review'

# Overrides EditableFieldsMixin to make title not required
title = models.TextField(validators=[validate_title], blank=True, default='')
Expand Down
2 changes: 1 addition & 1 deletion osf_tests/test_draft_registration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ def test_draft_registration_url(self):
project = factories.ProjectFactory()
draft = factories.DraftRegistrationFactory(branched_from=project)

assert draft.url == settings.DOMAIN + f'registries/drafts/{draft._id}'
assert draft.url == settings.DOMAIN + f'registries/drafts/{draft._id}/review'

def test_create_from_node_existing(self, user):
node = factories.ProjectFactory(creator=user)
Expand Down
Loading