Skip to content

Fix contentAvailability structure in Implicit3DTileContentSpec #12596 #12666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Vamonosraza
Copy link

Description

This PR fixes issue #12596 by updating the Voxel spec data to use the array format for contentAvailability as required by the latest 3D Tiles 1.1 specification.

The change make sure that test files follow the current specification while maintaining backward compatibility with the existing code that handles both formats.

I verified the changes by running the affected tests, which all passed successfully.

Screenshot 2025-06-10 at 1 18 53 PM

Issue number and link

#12596

Testing plan

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

Copy link

Thank you for the pull request, @Vamonosraza!

✅ We can confirm we have a CLA on file for you.

@Vamonosraza
Copy link
Author

What am I missing?

@javagl
Copy link
Contributor

javagl commented Jun 10, 2025

There's not necessarily something missing in terms of the checklist. It may take a moment until a PR is reviewed and merged, though.

  • The changes that you have done in Update CONTRIBUTORS.md #12667 can also be done in this PR (meaning that the other one could become obsolete).
  • I think that the glsl code block in the CHANGES.md is not necessary. (In fact, one could argue whether this should be mentioned in the CHANGES.md at all)

More importantly, regarding the fix itself: I've seen that you updated the quadtreeJson that was defined in the Implicit3DTileContentSpec.js. That makes sense, and should probably be part of this PR.

But the issue actually referred to the JSON files that are loaded as part of the specs, namely the files

@ggetz
Copy link
Contributor

ggetz commented Jul 14, 2025

@Vamonosraza Any update here? Can you please move the CONTRIBUTORS.md change to this PR and update CHANGES.md to match the next release on August 1?

@ggetz ggetz mentioned this pull request Jul 14, 2025
6 tasks
@mzschwartz5
Copy link
Contributor

Hi @Vamonosraza, I'm going to close this PR since we haven't seen any activity in a little while - but if you come back to it, please feel free to reopen the PR and continue the discussion. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants