Skip to content

fix: remove duplicate pubkey conversion #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2025
Merged

fix: remove duplicate pubkey conversion #531

merged 1 commit into from
Sep 18, 2025

Conversation

@GrapeBaBa
Copy link
Contributor

@GrapeBaBa GrapeBaBa commented Sep 17, 2025

This pull request makes a small change to the validateToRawMessage function in src/utils/buildRawMessage.ts, ensuring that the key property is always set to the provided publicKey rather than using publicKeyFromProtobuf(msg.key) again because it had been called in the previous code.

@GrapeBaBa GrapeBaBa requested a review from a team as a code owner September 17, 2025 05:11
wemeetagain
wemeetagain approved these changes Sep 18, 2025
View reviewed changes
Copy link
Member

@wemeetagain wemeetagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch

@wemeetagain wemeetagain merged commit 79f7cf0 into ChainSafe:master Sep 18, 2025
9 checks passed
@github-actions github-actions bot mentioned this pull request Sep 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GrapeBaBa @wemeetagain